Skip to contentSkip to conversation

PCI: Replace kmalloc with kzalloc in the comment/message

PATCH In review Yi Wang 2 participants 2 messages May 29, 2020 – Jul 7, 2020 PCI

lore
Share & tools
lore

Yi Wang

author
#0 lore raw

PATCH 1/1 PCI: Replace kmalloc with kzalloc in the comment/message

From: Liao Pingfang <[email protected]>

Use kzalloc instead of kmalloc in the comment/message according to the previous kzalloc() call.

---
 drivers/pci/hotplug/ibmphp_pci.c | 2 +-
 drivers/pci/setup-bus.c          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/pci/hotplug/ibmphp_pci.c +1 -1
index e22d023..2d36992 100644
@@ -205,7 +205,7 @@ int ibmphp_configure_card(struct pci_func *func, u8 slotno)
 								cur_func->next = newfunc;
 
 							rc = ibmphp_configure_card(newfunc, slotno);
-							/* This could only happen if kmalloc failed */
+							/* This could only happen if kzalloc failed */
 							if (rc) {
 								/* We need to do this in case bridge itself got configured properly, but devices behind it failed */
 								func->bus = 1; /* To indicate to the unconfigure function that this is a PPB */
drivers/pci/setup-bus.c +1 -1
index bbcef1a..13c5a44 100644
@@ -151,7 +151,7 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head)
 
 		tmp = kzalloc(sizeof(*tmp), GFP_KERNEL);
 		if (!tmp)
-			panic("pdev_sort_resources(): kmalloc() failed!\n");
+			panic("%s: kzalloc() failed!\n", __func__);
 		tmp->res = r;
 		tmp->dev = dev;
 
Signature · 1 line
2.9.5
#1 lore raw
Quoted 6 lines · Yi Wang

From: Liao Pingfang <[email protected]>

Use kzalloc instead of kmalloc in the comment/message according to the previous kzalloc() call.

I would be happy to apply this, but this needs to show a connection between Liao Pingfang and Yi Wang.

Ideally this patch would be sent directly by Liao Pingfang. The sender should at least appear in the Signed-off-by chain. See Documentation/process/submitting-patches.rst

Quoted 34 lines
---
 drivers/pci/hotplug/ibmphp_pci.c | 2 +-
 drivers/pci/setup-bus.c          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/pci/hotplug/ibmphp_pci.c +1 -1
index e22d023..2d36992 100644
@@ -205,7 +205,7 @@ int ibmphp_configure_card(struct pci_func *func, u8 slotno)
 								cur_func->next = newfunc;
 
 							rc = ibmphp_configure_card(newfunc, slotno);
-							/* This could only happen if kmalloc failed */
+							/* This could only happen if kzalloc failed */
 							if (rc) {
 								/* We need to do this in case bridge itself got configured properly, but devices behind it failed */
 								func->bus = 1; /* To indicate to the unconfigure function that this is a PPB */
drivers/pci/setup-bus.c +1 -1
index bbcef1a..13c5a44 100644
@@ -151,7 +151,7 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head)
 
 		tmp = kzalloc(sizeof(*tmp), GFP_KERNEL);
 		if (!tmp)
-			panic("pdev_sort_resources(): kmalloc() failed!\n");
+			panic("%s: kzalloc() failed!\n", __func__);
 		tmp->res = r;
 		tmp->dev = dev;
 
Signature · 1 line
2.9.5