Skip to contentSkip to conversation

IMA and fs

DISCUSSION [email protected] 2 participants 4 messages Apr 16, 2009 – Apr 17, 2009

lore
Share & tools
lore
#0 lore raw

I have found (at least) two issues about IMA.

1.
Calling stack
- kmem_cache_alloc(iint_cache, GFP_KERNEL)
- ima_inode_alloc()
- inode_init_always()
- xfs_iget_cache_hit()
- xfs_iget()

xfs_iget() holds spinlock before xfs_iget_cache_hit(), and ima_inode_alloc() cannot use GFP_KERNEL.

2.
ima_path_check() seems to be necessary before every opening a file. In 2.6.30-rc1, IMA produces lots of messages and stack trace when NFSD opens a file.
Does nfsd_open() need to to call ima_path_check()?

J. R. Okajima

#1 lore raw

[email protected] wrote on 04/16/2009 09:19:45 AM:

Quoted 10 lines

I have found (at least) two issues about IMA.

1.
Calling stack
- kmem_cache_alloc(iint_cache, GFP_KERNEL)
- ima_inode_alloc()
- inode_init_always()
- xfs_iget_cache_hit()
- xfs_iget()

Quoted 2 lines

xfs_iget() holds spinlock before xfs_iget_cache_hit(), and ima_inode_alloc() cannot use GFP_KERNEL.

This looks similar to the xfs - IMA problem discussed
http://lkml.org/lkml/2009/2/20/327.

Quoted 8 lines

2.
ima_path_check() seems to be necessary before every opening a file. In 2.6.30-rc1, IMA produces lots of messages and stack trace when NFSD opens a file.
Does nfsd_open() need to to call ima_path_check()?

J. R. Okajima

Yes, in order for the open/free to be balanced in ima_file_free().

Mimi Zohar

#2 lore raw

Mimi Zohar:

Quoted 5 lines
Quoted 2 lines

xfs_iget() holds spinlock before xfs_iget_cache_hit(), and ima_inode_alloc() cannot use GFP_KERNEL.

This looks similar to the xfs - IMA problem discussed
http://lkml.org/lkml/2009/2/20/327.

Yes, the same issue.
I didn't know it was discussed before.
So what is the conclusion? Are you waiting for fixing the spinlock in xfs?

Quoted 1 line
Quoted 1 line

Does nfsd_open() need to to call ima_path_check()?

	:::
Quoted 1 line

Yes, in order for the open/free to be balanced in ima_file_free().

Then how about putting ima_path_check() into __dentry_open() instead of may_open()?

J. R. Okajima

#3 lore raw

[email protected] wrote on 04/17/2009 09:57:46 AM:

Quoted 11 lines

Mimi Zohar:

Quoted 5 lines
Quoted 2 lines

xfs_iget() holds spinlock before xfs_iget_cache_hit(), and ima_inode_alloc() cannot use GFP_KERNEL.

This looks similar to the xfs - IMA problem discussed
http://lkml.org/lkml/2009/2/20/327.

Yes, the same issue.
I didn't know it was discussed before.
So what is the conclusion? Are you waiting for fixing the spinlock in xfs?

Yes. I just assumed, incorrectly, the xfs maintainer was notified. Am copying the xfs maintainer now.

Quoted 9 lines
Quoted 1 line
Quoted 1 line

Does nfsd_open() need to to call ima_path_check()?

:::

Quoted 1 line

Yes, in order for the open/free to be balanced in ima_file_free().

Then how about putting ima_path_check() into __dentry_open() instead of may_open()?

J. R. Okajima

Interesting. Am looking into it.

Thanks!

Mimi Zohar