Skip to contentSkip to conversation

drm/amdgpu/sriov: Disable pm for multiple vf sriov

PATCH In review Emily Deng 2 participants 4 messages Jun 2, 2020 – Jun 3, 2020

Subsystems (2)
lore
Share & tools
lore

Emily Deng

author
#0 lore raw

PATCH 1/1 drm/amdgpu/sriov: Disable pm for multiple vf sriov

Change-Id Ic010440ef625f6f29e91f267a6f284f9b6554e1f
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -0
index b6331712..fcbd875 100644
@@ -2004,6 +2004,9 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)
 	if (amdgpu_sriov_vf(adev))
 		amdgpu_virt_init_data_exchange(adev);
 
+	if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev))
+		adev->smu.pm_enabled = 0;
+
 	r = amdgpu_ib_pool_init(adev);
 	if (r) {
 		dev_err(adev->dev, "IB initialization failed (%d).\n", r);
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

Quoted 28 lines

-----Original Message-----
From: Emily Deng <[email protected]>
Sent: Tuesday, June 2, 2020 7:54 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>
Subject: [PATCH] drm/amdgpu/sriov: Disable pm for multiple vf sriov

Change-Id Ic010440ef625f6f29e91f267a6f284f9b6554e1f

---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++

1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -0
index b6331712..fcbd875 100644
@@ -2004,6 +2004,9 @@ static int amdgpu_device_ip_init(struct
 amdgpu_device *adev)
 if (amdgpu_sriov_vf(adev))
 amdgpu_virt_init_data_exchange(adev);
 
+if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev))
+adev->smu.pm_enabled = 0;
+
 r = amdgpu_ib_pool_init(adev);
 if (r) {
Quoted 3 lines

dev_err(adev->dev, "IB initialization failed (%d).\n", r); --
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#2 lore raw

[AMD Official Use Only - Internal Distribution Only]

Hi Emily,
How about to move it into smu_hw_init()?

Best Regards,
Frank

-----邮件原件-----
发件人: Deng, Emily <[email protected]>
发送时间: 2020年6月2日 20:08
收件人: Deng, Emily <[email protected]>; [email protected] 抄送: Min, Frank <[email protected]>
主题: RE: [PATCH] drm/amdgpu/sriov: Disable pm for multiple vf sriov

[AMD Official Use Only - Internal Distribution Only]

Quoted 29 lines

-----Original Message-----
From: Emily Deng <[email protected]>
Sent: Tuesday, June 2, 2020 7:54 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>
Subject: [PATCH] drm/amdgpu/sriov: Disable pm for multiple vf sriov

Change-Id Ic010440ef625f6f29e91f267a6f284f9b6554e1f

---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++

1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -1
index b6331712..fcbd875 100644
@@ -2004,6 +2004,9 @@ static int amdgpu_device_ip_init(struct
 amdgpu_device *adev)  if (amdgpu_sriov_vf(adev))
 amdgpu_virt_init_data_exchange(adev);
 
+if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev))
+adev->smu.pm_enabled = 0;
+
 r = amdgpu_ib_pool_init(adev);
 if (r) {
 dev_err(adev->dev, "IB initialization failed (%d).\n", r);
--
Quoted 1 line

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw

[AMD Official Use Only - Internal Distribution Only]

Thanks Frank, already sent out the modified patch, please help review again.

Best wishes
Emily Deng

Quoted 46 lines

-----Original Message-----
From: Min, Frank <[email protected]>
Sent: Tuesday, June 2, 2020 8:34 PM
To: Deng, Emily <[email protected]>; [email protected]
Subject: 回复: [PATCH] drm/amdgpu/sriov: Disable pm for multiple vf sriov

[AMD Official Use Only - Internal Distribution Only]

Hi Emily,
How about to move it into smu_hw_init()?

Best Regards,
Frank

-----邮件原件-----
发件人: Deng, Emily <[email protected]>
发送时间: 2020年6月2日 20:08
收件人: Deng, Emily <[email protected]>; amd- [email protected]
抄送: Min, Frank <[email protected]>
主题: RE: [PATCH] drm/amdgpu/sriov: Disable pm for multiple vf sriov

[AMD Official Use Only - Internal Distribution Only]

Quoted 22 lines

-----Original Message-----
From: Emily Deng <[email protected]>
Sent: Tuesday, June 2, 2020 7:54 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>
Subject: [PATCH] drm/amdgpu/sriov: Disable pm for multiple vf sriov

Change-Id Ic010440ef625f6f29e91f267a6f284f9b6554e1f

---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++

1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -0
index b6331712..fcbd875 100644
@@ -2004,6 +2004,9 @@ static int amdgpu_device_ip_init(struct
 amdgpu_device *adev)  if (amdgpu_sriov_vf(adev))
 amdgpu_virt_init_data_exchange(adev);
 
Quoted 10 lines
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -1
+if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev))
+adev->smu.pm_enabled = 0;
+
 r = amdgpu_ib_pool_init(adev);
 if (r) {
 dev_err(adev->dev, "IB initialization failed (%d).\n", r);
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx