exfat: Set the unused characters of FileName field to the value 0000h
Subsystems (2)
PATCH v2 1/1 exfat: Set the unused characters of FileName field to the value 0000h
Some fsck tool complain that padding part of the FileName field is not set to the value 0000h. So let's maintain filesystem cleaner, as exfat's spec. recommendation.
--- fs/exfat/dir.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
fs/exfat/dir.c +6 -4
@@ -425,10 +425,12 @@ static void exfat_init_name_entry(struct exfat_dentry *ep, ep->dentry.name.flags =0x0 ;for (i =0 ; i <EXFAT_FILE_NAME_LEN ; i++) { - ep->dentry.name.unicode_0_14[i] =cpu_to_le16 (*uniname); -if (*uniname ==0x0 ) -break ; - uniname++; +if (*uniname !=0x0 ) { + ep->dentry.name.unicode_0_14[i] =cpu_to_le16 (*uniname); + uniname++; + }else { + ep->dentry.name.unicode_0_14[i] =0x0 ; + } } }
Signature · 1 line
2.7.4
Quoted 5 lines
Some fsck tool complain that padding part of the FileName field is not set to the value 0000h. So let's maintain filesystem cleaner, as exfat's spec. recommendation.
Signe-off-by Hyeongseok.Kim <[email protected]>
Looks good to me. Thanks.
Quoted 28 lines
--- fs/exfat/dir.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)fs/exfat/dir.c +6
-4@@ -425,10 +425,12 @@ static void exfat_init_name_entry(struct exfat_dentry *ep, ep->dentry.name.flags =0x0 ;for (i =0 ; i <EXFAT_FILE_NAME_LEN ; i++) { - ep->dentry.name.unicode_0_14[i] =cpu_to_le16 (*uniname); -if (*uniname ==0x0 ) -break ; - uniname++; +if (*uniname !=0x0 ) { + ep->dentry.name.unicode_0_14[i] =cpu_to_le16 (*uniname); + uniname++; + }else { + ep->dentry.name.unicode_0_14[i] =0x0 ; + } }}
--
2.7.4
Namjae Jeon
AppliedQuoted 5 lines
Quoted 5 lines
Some fsck tool complain that padding part of the FileName field is not set to the value 0000h. So let's maintain filesystem cleaner, as exfat's spec. recommendation.
Signe-off-by Hyeongseok.Kim <[email protected]>
Fixed a typo: Signe -> Signed.
Quoted 4 lines
Reviewed-by Sungjong Seo <[email protected]>Looks good to me. Thanks.
Applied. Thanks!
Quoted 6 lines · Namjae Jeon
Quoted 5 lines
Quoted 5 lines
Some fsck tool complain that padding part of the FileName field is not set to the value 0000h. So let's maintain filesystem cleaner, as exfat's spec. recommendation.
Signe-off-by Hyeongseok.Kim <[email protected]>Fixed a typo: Signe -> Signed.
Oops.
Maybe I touched Signed-off-by tag while editing commit message, and forgot to do checkpatch on 2nd version. I'm sorry for bothering you and Thanks for fixing it.
Quoted 6 lines
Quoted 3 lines
Reviewed-by Sungjong Seo <[email protected]>Looks good to me. Thanks.
Applied. Thanks!