Skip to contentSkip to conversation

configs: ls1043aqds: Configure QSPI related configs

PATCH New Kuldeep Singh 3 participants 5 messages Jun 11, 2020 – Oct 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: ls1043aqds: Configure QSPI related configs

LS1043A-QDS has "s25fl128s" flash of size 16M with 64K sector size. The board requires few spi-flash related configs to be updated in TFA and QSPI _defconfigs.

Following are the changes:
- Define/Update CONFIG_ENV_ADDR
- Unset CONFIG_SPI_FLASH_BAR
- Correct CONFIG_ENV_SECT_SIZE
- Enable CONFIG_SYS_RELOC_GD_ENV_ADDR

---
 configs/ls1043aqds_qspi_defconfig            | 1 +
 configs/ls1043aqds_tfa_SECURE_BOOT_defconfig | 1 +
 configs/ls1043aqds_tfa_defconfig             | 3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)
configs/ls1043aqds_qspi_defconfig +1 -0
index a018b22..bb92b4c 100644
@@ -35,6 +35,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=spi0.0:1m(uboot),5m(kernel),1m(dtb),9m(file_sy
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="fsl-ls1043a-qds-duart"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_ENV_ADDR=0x40300000
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_DM=y
 CONFIG_SATA_CEVA=y
configs/ls1043aqds_tfa_SECURE_BOOT_defconfig +1 -0
index 3ee5d28..a9d7131 100644
@@ -48,6 +48,7 @@ CONFIG_SYS_FLASH_CFI=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_SPI_FLASH=y
 CONFIG_SF_DEFAULT_BUS=1
+# CONFIG_SPI_FLASH_BAR is not set
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_PHYLIB=y
 CONFIG_PHYLIB_10G=y
configs/ls1043aqds_tfa_defconfig +2 -1
index 297788b..eb1f905 100644
@@ -4,7 +4,7 @@ CONFIG_TFABOOT=y
 CONFIG_SYS_TEXT_BASE=0x82000000
 CONFIG_ENV_SIZE=0x2000
 CONFIG_ENV_OFFSET=0x500000
-CONFIG_ENV_SECT_SIZE=0x20000
+CONFIG_ENV_SECT_SIZE=0x10000
 CONFIG_DM_GPIO=y
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
@@ -43,6 +43,7 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_USE_ENV_SPI_BUS=y
 CONFIG_ENV_SPI_BUS=0
 CONFIG_ENV_ADDR=0x60500000
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_DM=y
 CONFIG_SATA_CEVA=y
 CONFIG_FSL_CAAM=y
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 configs: ls1043aqds: Configure QSPI related configs

Quoted 67 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Kuldeep Singh
Sent: Thursday, June 11, 2020 12:13 PM
To: u-boot at lists.denx.de
Cc: Priyanka Jain <[email protected]>; Kuldeep Singh <[email protected]>
Subject: [PATCH] configs: ls1043aqds: Configure QSPI related configs

LS1043A-QDS has "s25fl128s" flash of size 16M with 64K sector size. The board requires few spi-flash related configs to be updated in TFA and QSPI _defconfigs.

Following are the changes:
- Define/Update CONFIG_ENV_ADDR
- Unset CONFIG_SPI_FLASH_BAR
- Correct CONFIG_ENV_SECT_SIZE
- Enable CONFIG_SYS_RELOC_GD_ENV_ADDR

---

configs/ls1043aqds_qspi_defconfig            | 1 +
configs/ls1043aqds_tfa_SECURE_BOOT_defconfig | 1 +
configs/ls1043aqds_tfa_defconfig             | 3 ++-
3 files changed, 4 insertions(+), 1 deletion(-)
configs/ls1043aqds_qspi_defconfig +0 -0
index a018b22..bb92b4c 100644
@@ -35,6 +35,7 @@

CONFIG_MTDPARTS_DEFAULT="mtdparts=spi0.0:1m(uboot),5m(kernel),1m(d tb),9m(file_sy
CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="fsl-ls1043a-qds-duart" CONFIG_ENV_IS_IN_SPI_FLASH=y +CONFIG_ENV_ADDR=0x40300000 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_DM=y
CONFIG_SATA_CEVA=y

configs/ls1043aqds_tfa_SECURE_BOOT_defconfig +0 -0
index 3ee5d28..a9d7131 100644
@@ -48,6 +48,7 @@ CONFIG_SYS_FLASH_CFI=y  CONFIG_MTD_RAW_NAND=y

CONFIG_SPI_FLASH=y
CONFIG_SF_DEFAULT_BUS=1
+# CONFIG_SPI_FLASH_BAR is not set
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_PHYLIB=y
CONFIG_PHYLIB_10G=y

configs/ls1043aqds_tfa_defconfig +0 -0
index 297788b..eb1f905 100644
@@ -4,7 +4,7 @@ CONFIG_TFABOOT=y

CONFIG_SYS_TEXT_BASE=0x82000000
CONFIG_ENV_SIZE=0x2000
CONFIG_ENV_OFFSET=0x500000

configs/ls1043aqds_tfa_defconfig +1 -1
-CONFIG_ENV_SECT_SIZE=0x20000
+CONFIG_ENV_SECT_SIZE=0x10000

CONFIG_DM_GPIO=y
CONFIG_NR_DRAM_BANKS=2
CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y

configs/ls1043aqds_tfa_defconfig +0 -0
@@ -43,6 +43,7 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
Quoted 4 lines

CONFIG_USE_ENV_SPI_BUS=y
CONFIG_ENV_SPI_BUS=0
CONFIG_ENV_ADDR=0x60500000
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y

Please confirm that all boot-sources will work fine with this change.

Regards
Priyanka
<snip>

#2 lore raw

PATCH 1/1 configs: ls1043aqds: Configure QSPI related configs

[...]

Quoted 1 line

Please confirm that all boot-sources will work fine with this change.

Please hold both the patches for a moment. I will test other boot sources and will let you know the results.

#3 lore raw

PATCH 1/1 configs: ls1043aqds: Configure QSPI related configs

Quoted 11 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Kuldeep Singh
Sent: Thursday, July 23, 2020 11:02 AM
To: Priyanka Jain (OSS) <[email protected]>; u-boot at lists.denx.de
Subject: RE: [PATCH] configs: ls1043aqds: Configure QSPI related configs

[...]

Quoted 1 line

Please confirm that all boot-sources will work fine with this change.

Please hold both the patches for a moment. I will test other boot sources and will let you know the results.

Any update?

Regards
Priyanka

#4 lore raw

PATCH 1/1 configs: ls1043aqds: Configure QSPI related configs

Quoted 15 lines

-----Original Message-----
From: Priyanka Jain <[email protected]>
Sent: Friday, October 23, 2020 9:22 AM
To: Kuldeep Singh <[email protected]>; Priyanka Jain (OSS) <[email protected]>; u-boot at lists.denx.de
Subject: RE: [PATCH] configs: ls1043aqds: Configure QSPI related configs

Quoted 8 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Kuldeep Singh
Sent: Thursday, July 23, 2020 11:02 AM
To: Priyanka Jain (OSS) <[email protected]>;
u-boot at lists.denx.de
Subject: RE: [PATCH] configs: ls1043aqds: Configure QSPI related configs

Quoted 7 lines
Quoted 5 lines

[...]

Quoted 1 line

Please confirm that all boot-sources will work fine with this change.

Please hold both the patches for a moment. I will test other boot sources and will let you know the results.

Any update?

This seems to be a generalized problem and needs to be fixed in u-boot env. I will work on it and provide the fix soon.