Skip to contentSkip to conversation

FAILED: patch "[PATCH] net/mlx5: DR, Fix freeing in dr_create_rc_qp()" failed to apply to 5.7-stable tree

PATCH [email protected] 2 participants 2 messages Jun 19, 2020 – Jun 23, 2020

Subsystems (3)
Network drivers Stable branch Mellanox mlx5 core
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.7-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 47a357de2b6b706af3c9471d5042f9ba8907031e Mon Sep 17 00:00:00 2001
From: Denis Efremov <[email protected]>
Date: Mon, 1 Jun 2020 19:45:26 +0300
Subject: [PATCH] net/mlx5: DR, Fix freeing in dr_create_rc_qp()

Variable "in" in dr_create_rc_qp() is allocated with kvzalloc() and should be freed with kvfree().

Fixes 297cccebdc5a ("net/mlx5: DR, Expose an internal API to issue RDMA operations")
Cc [email protected]
Signed-off-by Denis Efremov <[email protected]>
Signed-off-by Saeed Mahameed <[email protected]>
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c +1 -1
index f421013b0b54..2ca79b9bde1f 100644
@@ -179,7 +179,7 @@ static struct mlx5dr_qp *dr_create_rc_qp(struct mlx5_core_dev *mdev,
 	MLX5_SET(create_qp_in, in, opcode, MLX5_CMD_OP_CREATE_QP);
 	err = mlx5_cmd_exec(mdev, in, inlen, out, sizeof(out));
 	dr_qp->qpn = MLX5_GET(create_qp_out, out, qpn);
-	kfree(in);
+	kvfree(in);
 	if (err)
 		goto err_in;
 	dr_qp->uar = attr->uar;
maintainer
#1 lore raw
Quoted 17 lines · On Fri, Jun 19, 2020 at 03:45:42PM +0200, [email protected] wrote:

The patch below does not apply to the 5.7-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 47a357de2b6b706af3c9471d5042f9ba8907031e Mon Sep 17 00:00:00 2001
From: Denis Efremov <[email protected]>
Date: Mon, 1 Jun 2020 19:45:26 +0300
Subject: [PATCH] net/mlx5: DR, Fix freeing in dr_create_rc_qp()

Quoted 7 lines

Variable "in" in dr_create_rc_qp() is allocated with kvzalloc() and should be freed with kvfree().

Fixes 297cccebdc5a ("net/mlx5: DR, Expose an internal API to issue RDMA operations")
Cc [email protected]
Signed-off-by Denis Efremov <[email protected]>
Signed-off-by Saeed Mahameed <[email protected]>

Conflict due to quite a lot of refactoring around QP. I've fixed it up and queued for 5.7 and 5.4.

Signature · 2 lines
Thanks,
Sasha