Skip to contentSkip to conversation

FAILED: patch "[PATCH] dm zoned: assign max_io_len correctly" failed to apply to 5.4-stable tree

PATCH [email protected] 2 participants 2 messages Jun 29, 2020 – Jun 30, 2020

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 7b2377486767503d47265e4d487a63c651f6b55d Mon Sep 17 00:00:00 2001
From: Hou Tao <[email protected]>
Date: Mon, 15 Jun 2020 11:33:23 +0800
Subject: [PATCH] dm zoned: assign max_io_len correctly

The unit of max_io_len is sector instead of byte (spotted through code review), so fix it.

Fixes 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
drivers/md/dm-zoned-target.c +1 -1
index a907a9446c0b..cf915009c306 100644
@@ -890,7 +890,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	}
 
 	/* Set target (no write same support) */
-	ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata) << 9;
+	ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata);
 	ti->num_flush_bios = 1;
 	ti->num_discard_bios = 1;
 	ti->num_write_zeroes_bios = 1;
#1 lore raw
Quoted 7 lines · On 2020/06/29 20:38, [email protected] wrote:

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

Greg,

I just sent to you and [email protected] a fixed patch that cleanly applies to 5.7.y, 5.4.y, 4.19.y and 4.14.y.

Thanks !

Quoted 34 lines

greg k-h

------------------ original commit in Linus's tree ------------------

From 7b2377486767503d47265e4d487a63c651f6b55d Mon Sep 17 00:00:00 2001
From: Hou Tao <[email protected]>
Date: Mon, 15 Jun 2020 11:33:23 +0800
Subject: [PATCH] dm zoned: assign max_io_len correctly

The unit of max_io_len is sector instead of byte (spotted through code review), so fix it.

Fixes 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
drivers/md/dm-zoned-target.c +1 -1
index a907a9446c0b..cf915009c306 100644
@@ -890,7 +890,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	}
 
 	/* Set target (no write same support) */
-	ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata) << 9;
+	ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata);
 	ti->num_flush_bios = 1;
 	ti->num_discard_bios = 1;
 	ti->num_write_zeroes_bios = 1;
Signature · 2 lines
Damien Le Moal
Western Digital Research