patch "usb: dwc2: gadget: Remove assigned but never used 'maxsize'" added to usb-testing

DISCUSSION Minas Harutyunyan 2 participants 3 messages Jul 3, 2020 2 messages not in the archive USB

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Minas Harutyunyan

author

2020-07-03 08:04 UTC #2 lore raw

Added [email protected] to recipient list. Minas

Quoted 72 lines · Minas Harutyunyan

Hi,
Quoted 9 lines · On 7/3/2020 11:34 AM, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
usb: dwc2: gadget: Remove assigned but never used 'maxsize'
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
Quoted 9 lines
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open.
If you have any questions about this process, please let me know.
Greg, I'll prefer if Lee Jones add "Fixes:" tag and resubmit v2.
Thanks,
Minas
Quoted 44 lines
From 7c7cb6cd92807cc226fc82ada053b8035317ab51 Mon Sep 17 00:00:00 2001
From: Lee Jones <[email protected]>
Date: Thu, 2 Jul 2020 15:46:05 +0100
Subject: usb: dwc2: gadget: Remove assigned but never used 'maxsize'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The value of 'maxsize' has not been checked since commit 729cac693eecf ("usb: dwc2: Change ISOC DDMA flow") back in 2018, so remove the set but unused variable, which fixes the following W=1 kernel build warning:
drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_fill_isoc_desc’:
   drivers/usb/dwc2/gadget.c:885:6: warning: variable ‘maxsize’ set but not used [-Wunused-but-set-variable]
   885 | u32 maxsize = 0;
   | ^~~~~~~
Cc Minas Harutyunyan <[email protected]>
Cc Ben Dooks <[email protected]>
Signed-off-by Lee Jones <[email protected]>
Link https://urldefense.com/v3/__https://lore.kernel.org/r/[email protected]__;!!A4F2R9G_pg!IhpSf7ldHd1TxgfEqGeDO5GoDgF26x79lj2HYkRvnVYaEq2TxwllvewSx9kfKtc$
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
   drivers/usb/dwc2/gadget.c | 3 +--
   1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/dwc2/gadget.c +1 -2
index ea7c9c73b4ff..d98c1df91db8 100644
@@ -880,11 +880,10 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
   	struct dwc2_dma_desc *desc;
   	struct dwc2_hsotg *hsotg = hs_ep->parent;
   	u32 index;
-	u32 maxsize = 0;
   	u32 mask = 0;
   	u8 pid = 0;
 
-	maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask);
+	dwc2_gadget_get_desc_params(hs_ep, &mask);
 
   	index = hs_ep->next_desc;
   	desc = &hs_ep->desc_list[index];

[email protected]

maintainer

2020-07-03 08:20 UTC #3 lore raw

Quoted 4 lines · Minas Harutyunyan

Added [email protected] to recipient list. Minas

Quoted 24 lines

Quoted 23 lines · Minas Harutyunyan
Hi,
Quoted 9 lines · On 7/3/2020 11:34 AM, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
usb: dwc2: gadget: Remove assigned but never used 'maxsize'
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
Quoted 9 lines
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open.
If you have any questions about this process, please let me know.
Greg, I'll prefer if Lee Jones add "Fixes:" tag and resubmit v2.

There is no "Fixes:" needed for something like this, I'm goign to leave it as-is, thanks.

greg k-h

Minas Harutyunyan

author Acked-by

2020-07-03 08:24 UTC #4 lore raw

Hi,

Quoted 24 lines · On 7/3/2020 12:20 PM, [email protected] wrote:

Quoted 23 lines · Minas Harutyunyan
Added [email protected] to recipient list. Minas
Quoted 18 lines · Minas Harutyunyan
Hi,
Quoted 15 lines · On 7/3/2020 11:34 AM, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
usb: dwc2: gadget: Remove assigned but never used 'maxsize'
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open.

Quoted 9 lines

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
If you have any questions about this process, please let me know.
Greg, I'll prefer if Lee Jones add "Fixes:" tag and resubmit v2.
There is no "Fixes:" needed for something like this, I'm goign to leave it as-is, thanks.

Ok.

Acked-by Minas Harutyunyan <[email protected]>

Thanks,
Minas

Quoted 2 lines

greg k-h