arm64: dts: qcom: sc7180: Add missing properties for Wifi node
Subsystems (4)
PATCH v2 1/1 arm64: dts: qcom: sc7180: Add missing properties for Wifi node
The wlan firmware memory is statically mapped in the Trusted Firmware, hence the wlan driver does not need to map/unmap this region dynamically.
Hence add the property to indicate the wlan driver to not map/unamp the firmware memory region dynamically.
Also add the chain1 voltage supply for wlan.
---
Changes from v1:
- Add the wifi mac alias
This patch is created on top of the change by Douglas Anderson.
https://lkml.org/lkml/2020/6/25/817
Also the dt-bindings for the chain1 voltage supply is added by the below patch series:
https://patchwork.kernel.org/project/linux-wireless/list/?series=309137
--- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/sc7180-idp.dts +3 -0
@@ -19,6 +19,7 @@ aliases { bluetooth0 = &bluetooth; + wifi0 = &wifi; hsuart0 = &uart3; serial0 = &uart8; };
@@ -391,10 +392,12 @@ &wifi { status = "okay"; + qcom,msa-fixed-perm; vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>; vdd-1.8-xo-supply = <&vreg_l1c_1p8>; vdd-1.3-rfa-supply = <&vreg_l2c_1p3>; vdd-3.3-ch0-supply = <&vreg_l10c_3p3>; + vdd-3.3-ch1-supply = <&vreg_l11c_3p3>; wifi-firmware { iommus = <&apps_smmu 0xc2 0x1>; };
Signature · 1 line
2.7.4
Hi,
Quoted 32 lines · Rakesh Pillai
The wlan firmware memory is statically mapped in the Trusted Firmware, hence the wlan driver does not need to map/unmap this region dynamically.
Hence add the property to indicate the wlan driver to not map/unamp the firmware memory region dynamically.
Also add the chain1 voltage supply for wlan.
Signed-off-by Rakesh Pillai <[email protected]>---
Changes from v1:
- Add the wifi mac aliasThis patch is created on top of the change by Douglas Anderson.
https://lkml.org/lkml/2020/6/25/817Also the dt-bindings for the chain1 voltage supply is added by the below patch series:
https://patchwork.kernel.org/project/linux-wireless/list/?series=309137--- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 3 +++ 1 file changed, 3 insertions(+)arch/arm64/boot/dts/qcom/sc7180-idp.dts +0
-0
arch/arm64/boot/dts/qcom/sc7180-idp.dts line 24
Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts +1
-0@@ -19,6 +19,7 @@ aliases { bluetooth0 = &bluetooth; + wifi0 = &wifi; hsuart0 = &uart3; serial0 = &uart8;
Could you alphabetize?
Quoted 4 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts +0
-0};@@ -391,10 +392,12 @@ &wifi {
arch/arm64/boot/dts/qcom/sc7180-idp.dts line 403
Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts +2
-0status = "okay"; + qcom,msa-fixed-perm; vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>; vdd-1.8-xo-supply = <&vreg_l1c_1p8>; vdd-1.3-rfa-supply = <&vreg_l2c_1p3>; vdd-3.3-ch0-supply = <&vreg_l10c_3p3>; + vdd-3.3-ch1-supply = <&vreg_l11c_3p3>; wifi-firmware { iommus = <&apps_smmu 0xc2 0x1>; };
Other than the alphabetical order:
Quoted 36 lines · Doug Anderson
Hi,
Quoted 33 lines · Rakesh Pillai
The wlan firmware memory is statically mapped in the Trusted Firmware, hence the wlan driver does not need to map/unmap this region dynamically.
Hence add the property to indicate the wlan driver to not map/unamp the firmware memory region dynamically.
Also add the chain1 voltage supply for wlan.
Signed-off-by Rakesh Pillai <[email protected]>---
Changes from v1:
- Add the wifi mac aliasThis patch is created on top of the change by Douglas Anderson.
https://lkml.org/lkml/2020/6/25/817Also the dt-bindings for the chain1 voltage supply is added by the below patch series:
https://patchwork.kernel.org/project/linux-wireless/list/?series=309137--- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 3 +++ 1 file changed, 3 insertions(+)arch/arm64/boot/dts/qcom/sc7180-idp.dts +0
-0@@ -19,6 +19,7 @@
Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts line 24
Quoted 5 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts +1
-0aliases { bluetooth0 = &bluetooth; + wifi0 = &wifi; hsuart0 = &uart3; serial0 = &uart8;Could you alphabetize?
I fixed this up while applying the patch.
Thanks,
Bjorn
Quoted 18 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts +0
-0};@@ -391,10 +392,12 @@ &wifi {arch/arm64/boot/dts/qcom/sc7180-idp.dts line 403
Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180-idp.dts +2
-0status = "okay"; + qcom,msa-fixed-perm; vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>; vdd-1.8-xo-supply = <&vreg_l1c_1p8>; vdd-1.3-rfa-supply = <&vreg_l2c_1p3>; vdd-3.3-ch0-supply = <&vreg_l10c_3p3>; + vdd-3.3-ch1-supply = <&vreg_l11c_3p3>; wifi-firmware { iommus = <&apps_smmu 0xc2 0x1>; };Other than the alphabetical order:
Reviewed-by Douglas Anderson <[email protected]>