nvmem: qcom-spmi-sdam: Enable multiple devices
Subsystems (2)
PATCH v2 1/1 nvmem: qcom-spmi-sdam: Enable multiple devices
Using pdev->id as the nvmem's config ID (which, by default, is NVMEM_DEVID_NONE) prevents multiple instances of this driver from probing because of the following error:
sysfs: cannot create duplicate filename '/bus/nvmem/devices/spmi_sdam'
Use NVMEM_DEVID_AUTO as the NVMEM config ID to fix the issue.
Signed-off-by Guru Das Srinagesh <[email protected]>
--- drivers/nvmem/qcom-spmi-sdam.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvmem/qcom-spmi-sdam.c +2 -2
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only /* -* Copyright (c) 2017 The Linux Foundation. All rights reserved. +* Copyright (c) 2017, 2020 The Linux Foundation. All rights reserved. */ #include <linux/device.h>
@@ -141,7 +141,7 @@ static int sdam_probe(struct platform_device *pdev) sdam->sdam_config.dev = &pdev->dev; sdam->sdam_config.name ="spmi_sdam" ; - sdam->sdam_config.id = pdev->id; + sdam->sdam_config.id =NVMEM_DEVID_AUTO ; sdam->sdam_config.owner =THIS_MODULE , sdam->sdam_config.stride =1 ; sdam->sdam_config.word_size =1 ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 4 lines · Guru Das Srinagesh
Using
pdev->idas the nvmem's config ID (which, by default, isNVMEM_DEVID_NONE) prevents multiple instances of this driver from probing because of the following error:
Quoted 8 lines
sysfs: cannot create duplicate filename '/bus/nvmem/devices/spmi_sdam'
Use
NVMEM_DEVID_AUTOas the NVMEM config ID to fix the issue.Signed-off-by Guru Das Srinagesh <[email protected]>--- drivers/nvmem/qcom-spmi-sdam.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied thanks,
--srini
Quoted 23 lines
drivers/nvmem/qcom-spmi-sdam.c +2
-2@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only /* -* Copyright (c) 2017 The Linux Foundation. All rights reserved. +* Copyright (c) 2017, 2020 The Linux Foundation. All rights reserved. */ #include <linux/device.h> @@ -141,7 +141,7 @@ static int sdam_probe(struct platform_device *pdev) sdam->sdam_config.dev = &pdev->dev; sdam->sdam_config.name ="spmi_sdam" ; - sdam->sdam_config.id = pdev->id; + sdam->sdam_config.id =NVMEM_DEVID_AUTO ; sdam->sdam_config.owner =THIS_MODULE , sdam->sdam_config.stride =1 ; sdam->sdam_config.word_size =1 ;