Extending hwmon ABI with attributes for rated values
Subsystems (2)
cover Extending hwmon ABI with attributes for rated values
This patch series is about extending hwmon ABI with new attributes for rated values. All of that is to cover PMBus specification which provides registers reporting rated values:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15
Zbigniew Lukwinski (3):
docs: hwmon: Add attributes to report rated values
hwmon: (core) Add support for rated attributes
hwmon: (pmbus/core) Add support for rated attributes
Documentation/hwmon/pmbus.rst | 15 ++++++- Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++ drivers/hwmon/hwmon.c | 10 +++++ drivers/hwmon/pmbus/pmbus.h | 13 ++++++ drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++---- include/linux/hwmon.h | 20 ++++++++++ 6 files changed, 168 insertions(+), 9 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/3 docs: hwmon: Add attributes to report rated values
New attributes (rated_min/rated_max) are being added the hwmon ABI. They are needed to cover rated values documented by PMBus specification:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15
--- Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+)
Documentation/hwmon/sysfs-interface.rst +70 -0
@@ -241,6 +241,20 @@ Voltages Affects the way the driver calculates the CPU core reference voltage from the vid pins. +`in[0-*]_rated_min` + Minimum rated voltage. + + Unit: millivolt + + RO + +`in[0-*]_rated_max` + Maximum rated voltage. + + Unit: millivolt + + RO + Also see the Alarms section for status flags associated with voltages.
@@ -574,6 +588,20 @@ Temperatures RW +`temp[1-*]_rated_min` + Minimum rated temperature. + + Unit: millidegree Celsius + + RO + +`temp[1-*]_rated_max` + Maximum rated temperature. + + Unit: millidegree Celsius + + RO + Some chips measure temperature using external thermistors and an ADC, and report the temperature measurement as a voltage. Converting this voltage back to a temperature (or the other way around for limits) requires
@@ -664,6 +692,20 @@ Currents RW +`curr[1-*]_rated_min` + Minimum rated current. + + Unit: milliampere + + RO + +`curr[1-*]_rated_max` + Maximum rated current. + + Unit: milliampere + + RO + Also see the Alarms section for status flags associated with currents. *****
@@ -830,6 +872,20 @@ Power RW +`power[1-*]_rated_min` + Minimum rated power. + + Unit: microWatt + + RO + +`power[1-*]_rated_max` + Maximum rated power. + + Unit: microWatt + + RO + Also see the Alarms section for status flags associated with power readings. ******
@@ -877,6 +933,20 @@ Humidity RW +`humidity[1-*]_rated_min` + Minimum rated humidity. + + Unit: milli-percent (per cent mille, pcm) + + RO + +`humidity[1-*]_rated_max` + Maximum rated humidity. + + Unit: milli-percent (per cent mille, pcm) + + RO + ****** Alarms ******
Signature · 1 line
2.7.4
PATCH 2/3 hwmon: (core) Add support for rated attributes
In reply to Zbigniew LukwinskiAdding implementation for new attributes (rated_min/rated_max) for currentX, inX, powerX, tempX and humidityX.
Tested with OpenBMC stack and simple hwmon driver using rated_min/rated_max for the following types of sensors: hwmon_temp, hwmon_in, hwmon_curr, hwmon_power, hwmon_humidity.
For each sensor rated attributes were available and returned expected values.
--- drivers/hwmon/hwmon.c | 10 ++++++++++ include/linux/hwmon.h | 20 ++++++++++++++++++++ 2 files changed, 30 insertions(+)
drivers/hwmon/hwmon.c +10 -0
@@ -431,6 +431,8 @@ static const char * const hwmon_temp_attr_templates[] = { [hwmon_temp_lowest] = "temp%d_lowest", [hwmon_temp_highest] = "temp%d_highest", [hwmon_temp_reset_history] = "temp%d_reset_history", + [hwmon_temp_rated_min] = "temp%d_rated_min", + [hwmon_temp_rated_max] = "temp%d_rated_max", };static const char *const hwmon_in_attr_templates[] = {
@@ -450,6 +452,8 @@ static const char * const hwmon_in_attr_templates[] = { [hwmon_in_max_alarm] = "in%d_max_alarm", [hwmon_in_lcrit_alarm] = "in%d_lcrit_alarm", [hwmon_in_crit_alarm] = "in%d_crit_alarm", + [hwmon_in_rated_min] = "in%d_rated_min", + [hwmon_in_rated_max] = "in%d_rated_max", };static const char *const hwmon_curr_attr_templates[] = {
@@ -469,6 +473,8 @@ static const char * const hwmon_curr_attr_templates[] = { [hwmon_curr_max_alarm] = "curr%d_max_alarm", [hwmon_curr_lcrit_alarm] = "curr%d_lcrit_alarm", [hwmon_curr_crit_alarm] = "curr%d_crit_alarm", + [hwmon_curr_rated_min] = "curr%d_rated_min", + [hwmon_curr_rated_max] = "curr%d_rated_max", };static const char *const hwmon_power_attr_templates[] = {
@@ -501,6 +507,8 @@ static const char * const hwmon_power_attr_templates[] = { [hwmon_power_max_alarm] = "power%d_max_alarm", [hwmon_power_lcrit_alarm] = "power%d_lcrit_alarm", [hwmon_power_crit_alarm] = "power%d_crit_alarm", + [hwmon_power_rated_min] = "power%d_rated_min", + [hwmon_power_rated_max] = "power%d_rated_max", };static const char *const hwmon_energy_attr_templates[] = {
@@ -519,6 +527,8 @@ static const char * const hwmon_humidity_attr_templates[] = { [hwmon_humidity_max_hyst] = "humidity%d_max_hyst", [hwmon_humidity_alarm] = "humidity%d_alarm", [hwmon_humidity_fault] = "humidity%d_fault", + [hwmon_humidity_rated_min] = "humidity%d_rated_min", + [hwmon_humidity_rated_max] = "humidity%d_rated_max", };static const char *const hwmon_fan_attr_templates[] = {
include/linux/hwmon.h +20 -0
@@ -85,6 +85,8 @@ enum hwmon_temp_attributes { hwmon_temp_lowest, hwmon_temp_highest, hwmon_temp_reset_history, + hwmon_temp_rated_min, + hwmon_temp_rated_max, };#define HWMON_T_ENABLE BIT(hwmon_temp_enable)
@@ -112,6 +114,8 @@ enum hwmon_temp_attributes {#define HWMON_T_LOWEST BIT(hwmon_temp_lowest)#define HWMON_T_HIGHEST BIT(hwmon_temp_highest)#define HWMON_T_RESET_HISTORY BIT(hwmon_temp_reset_history) +#define HWMON_T_RATED_MIN BIT(hwmon_temp_rated_min) +#define HWMON_T_RATED_MAX BIT(hwmon_temp_rated_max)enum hwmon_in_attributes { hwmon_in_enable,
@@ -130,6 +134,8 @@ enum hwmon_in_attributes { hwmon_in_max_alarm, hwmon_in_lcrit_alarm, hwmon_in_crit_alarm, + hwmon_in_rated_min, + hwmon_in_rated_max, };#define HWMON_I_ENABLE BIT(hwmon_in_enable)
@@ -148,6 +154,8 @@ enum hwmon_in_attributes {#define HWMON_I_MAX_ALARM BIT(hwmon_in_max_alarm)#define HWMON_I_LCRIT_ALARM BIT(hwmon_in_lcrit_alarm)#define HWMON_I_CRIT_ALARM BIT(hwmon_in_crit_alarm) +#define HWMON_I_RATED_MIN BIT(hwmon_in_rated_min) +#define HWMON_I_RATED_MAX BIT(hwmon_in_rated_max)enum hwmon_curr_attributes { hwmon_curr_enable,
@@ -166,6 +174,8 @@ enum hwmon_curr_attributes { hwmon_curr_max_alarm, hwmon_curr_lcrit_alarm, hwmon_curr_crit_alarm, + hwmon_curr_rated_min, + hwmon_curr_rated_max, };#define HWMON_C_ENABLE BIT(hwmon_curr_enable)
@@ -184,6 +194,8 @@ enum hwmon_curr_attributes {#define HWMON_C_MAX_ALARM BIT(hwmon_curr_max_alarm)#define HWMON_C_LCRIT_ALARM BIT(hwmon_curr_lcrit_alarm)#define HWMON_C_CRIT_ALARM BIT(hwmon_curr_crit_alarm) +#define HWMON_C_RATED_MIN BIT(hwmon_curr_rated_min) +#define HWMON_C_RATED_MAX BIT(hwmon_curr_rated_max)enum hwmon_power_attributes { hwmon_power_enable,
@@ -215,6 +227,8 @@ enum hwmon_power_attributes { hwmon_power_max_alarm, hwmon_power_lcrit_alarm, hwmon_power_crit_alarm, + hwmon_power_rated_min, + hwmon_power_rated_max, };#define HWMON_P_ENABLE BIT(hwmon_power_enable)
@@ -246,6 +260,8 @@ enum hwmon_power_attributes {#define HWMON_P_MAX_ALARM BIT(hwmon_power_max_alarm)#define HWMON_P_LCRIT_ALARM BIT(hwmon_power_lcrit_alarm)#define HWMON_P_CRIT_ALARM BIT(hwmon_power_crit_alarm) +#define HWMON_P_RATED_MIN BIT(hwmon_power_rated_min) +#define HWMON_P_RATED_MAX BIT(hwmon_power_rated_max)enum hwmon_energy_attributes { hwmon_energy_enable,
@@ -267,6 +283,8 @@ enum hwmon_humidity_attributes { hwmon_humidity_max_hyst, hwmon_humidity_alarm, hwmon_humidity_fault, + hwmon_humidity_rated_min, + hwmon_humidity_rated_max, };#define HWMON_H_ENABLE BIT(hwmon_humidity_enable)
@@ -278,6 +296,8 @@ enum hwmon_humidity_attributes {#define HWMON_H_MAX_HYST BIT(hwmon_humidity_max_hyst)#define HWMON_H_ALARM BIT(hwmon_humidity_alarm)#define HWMON_H_FAULT BIT(hwmon_humidity_fault) +#define HWMON_H_RATED_MIN BIT(hwmon_humidity_rated_min) +#define HWMON_H_RATED_MAX BIT(hwmon_humidity_rated_max)enum hwmon_fan_attributes { hwmon_fan_enable,
Signature · 1 line
2.7.4
PATCH 3/3 hwmon: (pmbus/core) Add support for rated attributes
In reply to Zbigniew LukwinskiAdding implementation for new attributes (rated_min/rated_max) to cover PMBus specification about rated values reporting:MFR_VIN_MIN, MFR_VIN_MAX, MFR_IIN_MAX, MFR_PIN_MAX, MFR_VOUT_MIN, MFR_VOUT_MAX, MFR_IOUT_MAX, MFR_POUT_MAX, MFR_MAX_TEMP_1/2/3.
Tested with OpenBMC stack. All rated attributes were available and reported correct values.
--- Documentation/hwmon/pmbus.rst | 15 +++++++++++- drivers/hwmon/pmbus/pmbus.h | 13 +++++++++++ drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++++++++++++++++------- 3 files changed, 68 insertions(+), 9 deletions(-)
Documentation/hwmon/pmbus.rst +14 -1
@@ -211,6 +211,10 @@ inX_lcrit_alarm Voltage critical low alarm. inX_crit_alarm Voltage critical high alarm. From VOLTAGE_OV_FAULT status. inX_label "vin", "vcap", or "voutY" +inX_rated_min Minimum rated voltage. + From MFR_VIN_MIN or MFR_VOUT_MIN register. +inX_rated_max Maximum rated voltage. + From MFR_VIN_MAX or MFR_VOUT_MAX register. currX_input Measured current. From READ_IIN or READ_IOUT register. currX_max Maximum current.
@@ -230,6 +234,8 @@ currX_crit_alarm Current critical high alarm. currX_label "iin", "iinY", "iinY.Z", "ioutY", or "ioutY.Z", where Y reflects the page number and Z reflects the phase. +currX_rated_max Maximum rated current. + From MFR_IIN_MAX or MFR_IOUT_MAX register. powerX_input Measured power. From READ_PIN or READ_POUT register. powerX_cap Output power cap. From POUT_MAX register.
@@ -244,10 +250,12 @@ powerX_crit_alarm Output power critical high alarm. powerX_label "pin", "pinY", "pinY.Z", "poutY", or "poutY.Z", where Y reflects the page number and Z reflects the phase. +powerX_rated_max Maximum rated power. + From MFR_PIN_MAX or MFR_POUT_MAX register. tempX_input Measured temperature. From READ_TEMPERATURE_X register. -tempX_min Mimimum temperature. From UT_WARN_LIMIT register. +tempX_min Minimum temperature. From UT_WARN_LIMIT register. tempX_max Maximum temperature. From OT_WARN_LIMIT register. tempX_lcrit Critical low temperature. From UT_FAULT_LIMIT register.
@@ -265,4 +273,9 @@ tempX_lcrit_alarm Chip temperature critical low alarm. Set by comparing tempX_crit_alarm Chip temperature critical high alarm. Set by comparing READ_TEMPERATURE_X with OT_FAULT_LIMIT if TEMP_OT_FAULT status is set. +tempX_rated_min Minimum rated temperature. + From MFR_TAMBIENT_MIN register. +tempX_rated_max Maximum rated temperature. + From MFR_TAMBIENT_MAX, MFR_MAX_TEMP_1, MFR_MAX_TEMP_2 or + MFR_MAX_TEMP_3 register. ======================= ========================================================
drivers/hwmon/pmbus/pmbus.h +13 -0
@@ -119,9 +119,22 @@ enum pmbus_regs {PMBUS_MFR_DATE =0x9D ,PMBUS_MFR_SERIAL =0x9E , +PMBUS_MFR_VIN_MIN =0xA0 , +PMBUS_MFR_VIN_MAX =0xA1 , +PMBUS_MFR_IIN_MAX =0xA2 , +PMBUS_MFR_PIN_MAX =0xA3 , +PMBUS_MFR_VOUT_MIN =0xA4 , +PMBUS_MFR_VOUT_MAX =0xA5 , +PMBUS_MFR_IOUT_MAX =0xA6 , +PMBUS_MFR_POUT_MAX =0xA7 , +PMBUS_IC_DEVICE_ID =0xAD ,PMBUS_IC_DEVICE_REV =0xAE , +PMBUS_MFR_MAX_TEMP_1 =0xC0 , +PMBUS_MFR_MAX_TEMP_2 =0xC1 , +PMBUS_MFR_MAX_TEMP_3 =0xC2 , +/* * Virtual registers. * Useful to support attributes which are not supported by standard PMBus
drivers/hwmon/pmbus/pmbus_core.c +41 -8
103 lines not on this page · raw message
Signature · 1 line
2.7.4
Guenter Roeck
maintainerQuoted 11 lines · Zbigniew Lukwinski
This patch series is about extending hwmon ABI with new attributes for rated values. All of that is to cover PMBus specification which provides registers reporting rated values:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15Zbigniew Lukwinski (3):
docs: hwmon: Add attributes to report rated values
hwmon: (core) Add support for rated attributes
hwmon: (pmbus/core) Add support for rated attributes
Quoted 8 lines
Documentation/hwmon/pmbus.rst | 15 ++++++- Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++ drivers/hwmon/hwmon.c | 10 +++++ drivers/hwmon/pmbus/pmbus.h | 13 ++++++ drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++---- include/linux/hwmon.h | 20 ++++++++++ 6 files changed, 168 insertions(+), 9 deletions(-)
I have been struggling with "rated_{min,max}" vs. "{min,max}_rated", but then figured it does not really make a difference, and rated_ as prefix may actually make more sense. I'll queue the series for v5.10. Let's see if there is any feedback.
Thanks,
Guenter
Quoted 20 lines · Guenter Roeck
Quoted 11 lines · Zbigniew Lukwinski
This patch series is about extending hwmon ABI with new attributes for rated values. All of that is to cover PMBus specification which provides registers reporting rated values:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15Zbigniew Lukwinski (3):
docs: hwmon: Add attributes to report rated values
hwmon: (core) Add support for rated attributes
hwmon: (pmbus/core) Add support for rated attributesQuoted 8 lines
Documentation/hwmon/pmbus.rst | 15 ++++++- Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++ drivers/hwmon/hwmon.c | 10 +++++ drivers/hwmon/pmbus/pmbus.h | 13 ++++++ drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++---- include/linux/hwmon.h | 20 ++++++++++ 6 files changed, 168 insertions(+), 9 deletions(-)
Quoted 7 lines
I have been struggling with "rated_{min,max}" vs. "{min,max}_rated", but then figured it does not really make a difference, and
rated_as prefix may actually make more sense. I'll queue the series for v5.10. Let's see if there is any feedback.Thanks,
Guenter
Sure.
Thanks,
Zbigniew