Skip to contentSkip to conversation

arm64: dts: sdm845: Fixup OPP table for all qup devices

PATCH In review Rajendra Nayak 4 participants 6 messages Aug 12, 2020 – Sep 14, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: sdm845: Fixup OPP table for all qup devices

This OPP table was based on the clock VDD-FMAX tables seen in downstream code, however it turns out the downstream clock driver does update these tables based on later/production rev of the chip and whats seen in the tables belongs to an early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the production rev of sdm845 SoC.

Fixes 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup

devices")

---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +7 -2
index 2884577..eca81cf 100644
@@ -1093,8 +1093,8 @@
 		qup_opp_table: qup-opp-table {
 			compatible = "operating-points-v2";
 
-			opp-19200000 {
-				opp-hz = /bits/ 64 <19200000>;
+			opp-50000000 {
+				opp-hz = /bits/ 64 <50000000>;
 				required-opps = <&rpmhpd_opp_min_svs>;
 			};
 
@@ -1107,6 +1107,11 @@
 				opp-hz = /bits/ 64 <100000000>;
 				required-opps = <&rpmhpd_opp_svs>;
 			};
+
+			opp-128000000 {
+				opp-hz = /bits/ 64 <128000000>;
+				required-opps = <&rpmhpd_opp_nom>;
+			};
 		};
 
 		qupv3_id_0: geniqup@8c0000 {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Tested-by on v1 1/1
#1 lore raw
Quoted 11 lines · Rajendra Nayak

This OPP table was based on the clock VDD-FMAX tables seen in downstream code, however it turns out the downstream clock driver does update these tables based on later/production rev of the chip and whats seen in the tables belongs to an early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the production rev of sdm845 SoC.

Fixes 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup

devices")

Fixes BT on Xiaomi Poco F1 phone running AOSP.

Quoted 37 lines
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +7 -3
index 2884577..eca81cf 100644
@@ -1093,8 +1093,8 @@
                qup_opp_table: qup-opp-table {
                        compatible = "operating-points-v2";
 
-                       opp-19200000 {
-                               opp-hz = /bits/ 64 <19200000>;
+                       opp-50000000 {
+                               opp-hz = /bits/ 64 <50000000>;
                                required-opps = <&rpmhpd_opp_min_svs>;
                        };
 
@@ -1107,6 +1107,11 @@
                                opp-hz = /bits/ 64 <100000000>;
                                required-opps = <&rpmhpd_opp_svs>;
                        };
+
+                       opp-128000000 {
+                               opp-hz = /bits/ 64 <128000000>;
+                               required-opps = <&rpmhpd_opp_nom>;
+                       };
                };
 
                qupv3_id_0: geniqup@8c0000 {
--

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Tested-by on v1 1/1
#2 lore raw
In reply to Rajendra Nayak
Quoted 9 lines · Rajendra Nayak

This OPP table was based on the clock VDD-FMAX tables seen in downstream code, however it turns out the downstream clock driver does update these tables based on later/production rev of the chip and whats seen in the tables belongs to an early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the production rev of sdm845 SoC.

Quoted 5 lines
Fixes 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup

devices")

---

Just wanted to follow up on this, as it's still missing from 5.9-rc3 and is needed to fix a bluetooth regression on db845c from 5.9-rc1.

Amit has already validated it (on PocoF1 as well), but just in case its useful:

thanks
-john

#3 lore raw
Quoted 15 lines · John Stultz
Quoted 8 lines · Rajendra Nayak

This OPP table was based on the clock VDD-FMAX tables seen in downstream code, however it turns out the downstream clock driver does update these tables based on later/production rev of the chip and whats seen in the tables belongs to an early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the production rev of sdm845 SoC.

Quoted 5 lines
Fixes 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup

devices")

---

Quoted 5 lines

Just wanted to follow up on this, as it's still missing from 5.9-rc3 and is needed to fix a bluetooth regression on db845c from 5.9-rc1.

Amit has already validated it (on PocoF1 as well), but just in case its useful:

Hey Everyone,
Just wanted to nag folks on this again as it is still missing from
upstream and resolves a bluetooth regression from 5.9-rc1.

thanks
-john

#4 lore raw
Quoted 20 lines · John Stultz
Quoted 18 lines · John Stultz
Quoted 8 lines · Rajendra Nayak

This OPP table was based on the clock VDD-FMAX tables seen in downstream code, however it turns out the downstream clock driver does update these tables based on later/production rev of the chip and whats seen in the tables belongs to an early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the production rev of sdm845 SoC.

Quoted 5 lines
Fixes 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup

devices")

---

Just wanted to follow up on this, as it's still missing from 5.9-rc3 and is needed to fix a bluetooth regression on db845c from 5.9-rc1.

Quoted 6 lines
Quoted 2 lines

Amit has already validated it (on PocoF1 as well), but just in case its useful:

Hey Everyone,
Just wanted to nag folks on this again as it is still missing from
upstream and resolves a bluetooth regression from 5.9-rc1.

Hey Everyone,
Just your weekly nag on this patch that is still missing upstream.
This patch fixes bluetooth regressions that started w/ 5.9-rc1. It would be great to see it land before 5.9 is finalized.

thanks
-john

#5 lore raw
Quoted 24 lines · John Stultz
Quoted 15 lines · John Stultz
Quoted 14 lines · John Stultz
Quoted 13 lines · Rajendra Nayak

This OPP table was based on the clock VDD-FMAX tables seen in downstream code, however it turns out the downstream clock driver does update these tables based on later/production rev of the chip and whats seen in the tables belongs to an early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the production rev of sdm845 SoC.

Fixes 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup

devices")

---

Quoted 8 lines
Quoted 5 lines

Just wanted to follow up on this, as it's still missing from 5.9-rc3 and is needed to fix a bluetooth regression on db845c from 5.9-rc1.

Amit has already validated it (on PocoF1 as well), but just in case its useful:

Hey Everyone,
Just wanted to nag folks on this again as it is still missing from
upstream and resolves a bluetooth regression from 5.9-rc1.

Quoted 7 lines

Hey Everyone,
Just your weekly nag on this patch that is still missing upstream.
This patch fixes bluetooth regressions that started w/ 5.9-rc1. It would be great to see it land before 5.9 is finalized.

thanks
-john

Also tested that this fixes it for the Lenovo Yoga C630