f2fs: fix indefinite loop scanning for free nid
PATCH 1/1 f2fs: fix indefinite loop scanning for free nid
If the sbi->ckpt->next_free_nid is not NAT block aligned and if there are free nids in that NAT block between the start of the block and next_free_nid, then those free nids will not be scanned in scan_nat_page(). This results into mismatch between nm_i->available_nids and the sum of nm_i->free_nid_count of all NAT blocks scanned. And nm_i->available_nids will always be greater than the sum of free nids in all the blocks. Under this condition, if we use all the currently scanned free nids, then it will loop forever in f2fs_alloc_nid() as nm_i->available_nids is still not zero but nm_i->free_nid_count of that partially scanned NAT block is zero.
Fix this to align the nm_i->next_scan_nid to the first nid of the corresponding NAT block.
--- fs/f2fs/node.c | 2 ++ 1 file changed, 2 insertions(+)
fs/f2fs/node.c +2 -0
@@ -2402,6 +2402,8 @@ static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi,if (IS_ERR (page)) { ret =PTR_ERR (page); }else { +if (nid %NAT_ENTRY_PER_BLOCK ) + nid =NAT_BLOCK_OFFSET (nid) *NAT_ENTRY_PER_BLOCK ; ret =scan_nat_page (sbi, page, nid);f2fs_put_page (page,1 ); }
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 24 lines · Sahitya Tummala
If the
sbi->ckpt->next_free_nidis not NAT block aligned and if there are free nids in that NAT block between the start of the block andnext_free_nid, then those free nids will not be scanned inscan_nat_page(). This results into mismatch betweennm_i->available_nidsand the sum ofnm_i->free_nid_countof all NAT blocks scanned. Andnm_i->available_nidswill always be greater than the sum of free nids in all the blocks. Under this condition, if we use all the currently scanned free nids, then it will loop forever inf2fs_alloc_nid()asnm_i->available_nidsis still not zero butnm_i->free_nid_countof that partially scanned NAT block is zero.Fix this to align the
nm_i->next_scan_nidto the first nid of the corresponding NAT block.Signed-off-by Sahitya Tummala <[email protected]>--- fs/f2fs/node.c | 2 ++ 1 file changed, 2 insertions(+)fs/f2fs/node.c +0
-0
fs/f2fs/node.c static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi, · line 2406
Quoted 5 lines
fs/f2fs/node.c +2
-0@@ -2402,6 +2402,8 @@ static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi,if (IS_ERR (page)) { ret =PTR_ERR (page); }else { +if (nid %NAT_ENTRY_PER_BLOCK ) + nid =NAT_BLOCK_OFFSET (nid) *NAT_ENTRY_PER_BLOCK ;
How about moving this logic to the beginning of __f2fs_build_free_nids(), after nid reset?
BTW, it looks we can add unlikely in this judgment condition?
Thanks,
Quoted 4 lines
fs/f2fs/node.c +0
-0ret =scan_nat_page (sbi, page, nid);f2fs_put_page (page,1 ); }
Quoted 20 lines · Chao Yu
Quoted 19 lines · Sahitya Tummala
If the
sbi->ckpt->next_free_nidis not NAT block aligned and if there are free nids in that NAT block between the start of the block andnext_free_nid, then those free nids will not be scanned inscan_nat_page(). This results into mismatch betweennm_i->available_nidsand the sum ofnm_i->free_nid_countof all NAT blocks scanned. Andnm_i->available_nidswill always be greater than the sum of free nids in all the blocks. Under this condition, if we use all the currently scanned free nids, then it will loop forever inf2fs_alloc_nid()asnm_i->available_nidsis still not zero butnm_i->free_nid_countof that partially scanned NAT block is zero.Fix this to align the
nm_i->next_scan_nidto the first nid of the corresponding NAT block.Signed-off-by Sahitya Tummala <[email protected]>--- fs/f2fs/node.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 14 lines
fs/f2fs/node.c static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi, · line 2406
Quoted 10 lines
fs/f2fs/node.c +2
-0@@ -2402,6 +2402,8 @@ static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi,if (IS_ERR (page)) { ret =PTR_ERR (page); }else { +if (nid %NAT_ENTRY_PER_BLOCK ) + nid =NAT_BLOCK_OFFSET (nid) *NAT_ENTRY_PER_BLOCK ;How about moving this logic to the beginning of
__f2fs_build_free_nids(), after nid reset?
Sure, I will move it.
Quoted 1 line
BTW, it looks we can add unlikely in this judgment condition?
But it may not be an unlikely as it can happen whenever checkpoint is done, based on the next available free nid in function next_free_nid(), which can happen quite a few times, right?
Hitting the loop forever issue condition due to this could be a rare/difficult to reproduce but this check itself may not be unlikely in my opinion.
Thanks,
Quoted 7 lines
Thanks,
Quoted 4 lines
fs/f2fs/node.c +0
-0ret =scan_nat_page (sbi, page, nid);f2fs_put_page (page,1 ); }
Signature · 3 lines
-- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Quoted 36 lines · Sahitya Tummala
Quoted 20 lines · Chao Yu
Quoted 19 lines · Sahitya Tummala
If the
sbi->ckpt->next_free_nidis not NAT block aligned and if there are free nids in that NAT block between the start of the block andnext_free_nid, then those free nids will not be scanned inscan_nat_page(). This results into mismatch betweennm_i->available_nidsand the sum ofnm_i->free_nid_countof all NAT blocks scanned. Andnm_i->available_nidswill always be greater than the sum of free nids in all the blocks. Under this condition, if we use all the currently scanned free nids, then it will loop forever inf2fs_alloc_nid()asnm_i->available_nidsis still not zero butnm_i->free_nid_countof that partially scanned NAT block is zero.Fix this to align the
nm_i->next_scan_nidto the first nid of the corresponding NAT block.Signed-off-by Sahitya Tummala <[email protected]>--- fs/f2fs/node.c | 2 ++ 1 file changed, 2 insertions(+)Quoted 14 lines
fs/f2fs/node.c static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi, · line 2406
Quoted 10 lines
fs/f2fs/node.c +2
-0@@ -2402,6 +2402,8 @@ static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi,if (IS_ERR (page)) { ret =PTR_ERR (page); }else { +if (nid %NAT_ENTRY_PER_BLOCK ) + nid =NAT_BLOCK_OFFSET (nid) *NAT_ENTRY_PER_BLOCK ;How about moving this logic to the beginning of
__f2fs_build_free_nids(), after nid reset?
Quoted 7 lines
Sure, I will move it.
Quoted 1 line
BTW, it looks we can add unlikely in this judgment condition?
But it may not be an unlikely as it can happen whenever checkpoint is done, based on the next available free nid in function
next_free_nid(), which can happen quite a few times, right?
Oh, yes, I missed that place, please ignore that suggestion.. :)
Thanks,
Quoted 14 lines
Hitting the loop forever issue condition due to this could be a rare/difficult to reproduce but this check itself may not be unlikely in my opinion.
Thanks,
Quoted 7 lines
Thanks,
Quoted 4 lines
fs/f2fs/node.c +0
-0ret =scan_nat_page (sbi, page, nid);f2fs_put_page (page,1 ); }
Quoted 38 lines · Sahitya Tummala
Quoted 20 lines · Chao Yu
Quoted 19 lines · Sahitya Tummala
If the
sbi->ckpt->next_free_nidis not NAT block aligned and if there are free nids in that NAT block between the start of the block andnext_free_nid, then those free nids will not be scanned inscan_nat_page(). This results into mismatch betweennm_i->available_nidsand the sum ofnm_i->free_nid_countof all NAT blocks scanned. Andnm_i->available_nidswill always be greater than the sum of free nids in all the blocks. Under this condition, if we use all the currently scanned free nids, then it will loop forever inf2fs_alloc_nid()asnm_i->available_nidsis still not zero butnm_i->free_nid_countof that partially scanned NAT block is zero.Fix this to align the
nm_i->next_scan_nidto the first nid of the corresponding NAT block.Signed-off-by Sahitya Tummala <[email protected]>--- fs/f2fs/node.c | 2 ++ 1 file changed, 2 insertions(+)Quoted 14 lines
fs/f2fs/node.c static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi, · line 2406
Quoted 10 lines
fs/f2fs/node.c +2
-0@@ -2402,6 +2402,8 @@ static int __f2fs_build_free_nids(struct f2fs_sb_info *sbi,if (IS_ERR (page)) { ret =PTR_ERR (page); }else { +if (nid %NAT_ENTRY_PER_BLOCK ) + nid =NAT_BLOCK_OFFSET (nid) *NAT_ENTRY_PER_BLOCK ;How about moving this logic to the beginning of
__f2fs_build_free_nids(), after nid reset?Sure, I will move it.
Quoted 9 lines
Quoted 1 line
BTW, it looks we can add unlikely in this judgment condition?
But it may not be an unlikely as it can happen whenever checkpoint is done, based on the next available free nid in function
next_free_nid(), which can happen quite a few times, right?Hitting the loop forever issue condition due to this could be a rare/difficult to reproduce but this check itself may not be unlikely in my opinion.
Sorry, I was wrong above. During CP we update only ckpt->next_free_nid but not the nm_i->next_free_nid, which is done only once during boot up.
So yes, I will mark it as unlikely conditiona.
Thanks,
Quoted 14 lines
Thanks,
Quoted 7 lines
Thanks,
Quoted 4 lines
fs/f2fs/node.c +0
-0ret =scan_nat_page (sbi, page, nid);f2fs_put_page (page,1 ); }Signature · 3 lines
-- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Signature · 3 lines
-- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.