hwmon: pwm-fan: Use dev_err_probe() to simplify error handling
PATCH 1/1 hwmon: pwm-fan: Use dev_err_probe() to simplify error handling
dev_err_probe() can reduce code size, uniform error handling and record the defer probe reason etc., use it to simplify the code.
Signed-off-by Anson Huang <[email protected]>
--- drivers/hwmon/pwm-fan.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/hwmon/pwm-fan.c +2 -8
@@ -293,14 +293,8 @@ static int pwm_fan_probe(struct platform_device *pdev)mutex_init (&ctx->lock); ctx->pwm =devm_of_pwm_get (dev, dev->of_node,NULL ); -if (IS_ERR (ctx->pwm)) { - ret =PTR_ERR (ctx->pwm); - -if (ret != -EPROBE_DEFER ) -dev_err (dev,"Could not get PWM: %d\n" , ret); - -return ret; - } +if (IS_ERR (ctx->pwm)) +return dev_err_probe (dev,PTR_ERR (ctx->pwm),"Could not get PWM\n" );platform_set_drvdata (pdev, ctx);
Signature · 1 line
2.7.4
Quoted 4 lines · Anson Huang
dev_err_probe()can reduce code size, uniform error handling and record the defer probe reason etc., use it to simplify the code.Signed-off-by Anson Huang <[email protected]>
Applied.
Thanks,
Guenter
Quoted 25 lines
--- drivers/hwmon/pwm-fan.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)drivers/hwmon/pwm-fan.c +2
-8@@ -293,14 +293,8 @@ static int pwm_fan_probe(struct platform_device *pdev)mutex_init (&ctx->lock); ctx->pwm =devm_of_pwm_get (dev, dev->of_node,NULL ); -if (IS_ERR (ctx->pwm)) { - ret =PTR_ERR (ctx->pwm); - -if (ret != -EPROBE_DEFER ) -dev_err (dev,"Could not get PWM: %d\n" , ret); - -return ret; - } +if (IS_ERR (ctx->pwm)) +return dev_err_probe (dev,PTR_ERR (ctx->pwm),"Could not get PWM\n" );platform_set_drvdata (pdev, ctx);