Skip to contentSkip to conversation

clocksource/drivers/timer-gx6605s: Fixup counter reload

PATCH Applied [email protected] 3 participants 3 messages Aug 18, 2020 – Sep 27, 2020

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 clocksource/drivers/timer-gx6605s: Fixup counter reload

From: Guo Ren <[email protected]>

When the timer counts to the upper limit, an overflow interrupt is generated, and the count is reset with the value in the TIME_INI register. But the software expects to start counting from 0 when the count overflows, so it forces TIME_INI to 0 to solve the potential interrupt storm problem.

Cc Daniel Lezcano <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
 drivers/clocksource/timer-gx6605s.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clocksource/timer-gx6605s.c +1 -0
index 80d0939..8d386ad 100644
@@ -28,6 +28,7 @@ static irqreturn_t gx6605s_timer_interrupt(int irq, void *dev)
 	void __iomem *base = timer_of_base(to_timer_of(ce));
 
 	writel_relaxed(GX6605S_STATUS_CLR, base + TIMER_STATUS);
+	writel_relaxed(0, base + TIMER_INI);
 
 	ce->event_handler(ce);
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 8 lines · On 18/08/2020 09:31, [email protected] wrote:

From: Guo Ren <[email protected]>

When the timer counts to the upper limit, an overflow interrupt is generated, and the count is reset with the value in the TIME_INI register. But the software expects to start counting from 0 when the count overflows, so it forces TIME_INI to 0 to solve the potential interrupt storm problem.

Quoted 5 lines
Cc Daniel Lezcano <[email protected]>
Cc Thomas Gleixner <[email protected]>

---

Applied, thanks

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
merge bot Applied
#2 lore raw
In reply to [email protected]
The following commit has been merged into the timers/urgent branch of tip:

The following commit has been merged into the timers/urgent branch of tip:

Commit-ID:     bc6717d55d07110d8f3c6d31ec2af50c11b07091
Gitweb:        https://git.kernel.org/tip/bc6717d55d07110d8f3c6d31ec2af50c11b07091
Author:        Guo Ren <[email protected]>
AuthorDate:    Tue, 18 Aug 2020 07:31:17 
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Mon, 24 Aug 2020 13:01:39 +02:00

clocksource/drivers/timer-gx6605s: Fixup counter reload

When the timer counts to the upper limit, an overflow interrupt is generated, and the count is reset with the value in the TIME_INI register. But the software expects to start counting from 0 when the count overflows, so it forces TIME_INI to 0 to solve the potential interrupt storm problem.

---
 drivers/clocksource/timer-gx6605s.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clocksource/timer-gx6605s.c +1 -0
index 80d0939..8d386ad 100644
@@ -28,6 +28,7 @@ static irqreturn_t gx6605s_timer_interrupt(int irq, void *dev)
 	void __iomem *base = timer_of_base(to_timer_of(ce));
 
 	writel_relaxed(GX6605S_STATUS_CLR, base + TIMER_STATUS);
+	writel_relaxed(0, base + TIMER_INI);
 
 	ce->event_handler(ce);