Skip to contentSkip to conversation

FAILED: patch "[PATCH] drm/ast: Initialize DRAM type before posting GPU" failed to apply to 5.8-stable tree

PATCH [email protected] 1 participant 1 message Aug 19, 2020

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.8-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 244d012801dae30c91983b360457c78d481584b0 Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <[email protected]>
Date: Thu, 16 Jul 2020 14:53:52 +0200
Subject: [PATCH] drm/ast: Initialize DRAM type before posting GPU

Posting the GPU requires the correct DRAM type to be stored in struct ast_private. Therefore first initialize the DRAM info and then post the GPU. This restores the original order of instructions in this function.

Fixes bad09da6deab ("drm/ast: Fixed vram size incorrect issue on POWER")
Cc Joel Stanley <[email protected]>
Cc Y.C. Chen <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Emil Velikov <[email protected]>
Cc "Y.C. Chen" <[email protected]>
Cc <[email protected]> # v4.11+
drivers/gpu/drm/ast/ast_main.c +3 -3
index b162cc82204d..87e5baded2a7 100644
@@ -418,15 +418,15 @@ int ast_driver_load(struct drm_device *dev, unsigned long flags)
 
 	ast_detect_chip(dev, &need_post);
 
-	if (need_post)
-		ast_post_gpu(dev);
-
 	ret = ast_get_dram_info(dev);
 	if (ret)
 		goto out_free;
 	drm_info(dev, "dram MCLK=%u Mhz type=%d bus_width=%d\n",
 		 ast->mclk, ast->dram_type, ast->dram_bus_width);
 
+	if (need_post)
+		ast_post_gpu(dev);
+
 	ret = ast_mm_init(ast);
 	if (ret)
 		goto out_free;