connman-conf: make connman-conf only available for qemuall
PATCH v2 1/1 connman-conf: make connman-conf only available for qemuall
connman-conf is only for qemu machines, so use COMPATIBLE_MACHINE to limit that it is only available for qemuall, or else it can be built successfully without the package connman-conf generated.
--- meta/recipes-connectivity/connman/connman-conf.bb | 2 ++ meta/recipes-connectivity/connman/connman_1.38.bb | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
meta/recipes-connectivity/connman/connman-conf.bb +2 -0
@@ -34,3 +34,5 @@ do_install() { } SYSTEMD_SERVICE_${PN}_qemuall = "wired-connection.service" +COMPATIBLE_MACHINE = "null" +COMPATIBLE_MACHINE_qemuall = "${MACHINE}"
meta/recipes-connectivity/connman/connman_1.38.bb +1 -1
@@ -12,5 +12,5 @@ SRC_URI_append_libc-musl = " file://0002-resolve-musl-does-not-implement-res_nin SRC_URI[md5sum] = "1ed8745354c7254bdfd4def54833ee94" SRC_URI[sha256sum] = "cb30aca97c2f79ccaed8802aa2909ac5100a3969de74c0af8a9d73b85fc4932b" -RRECOMMENDS_${PN} = "connman-conf" +RRECOMMENDS_${PN}_qemuall = "connman-conf" RCONFLICTS_${PN} = "networkmanager"
Signature · 1 line
1.9.1
Why is this an issue?
connman-conf recipe doesn't take long time to build and if you don't want to install it on target you can use BAD_RECOMMENDATIONS variable.
We're using connman-conf to configure networking on various target machines
- not only on qemu*. If this is merged I'll just undo this in our layer - and that's fine, but if there are more people using connman-conf like this, then we should re-consider this commit (or at least better explain why it's needed in commit message).
Quoted 40 lines · Li Zhou
connman-conf is only for qemu machines, so use
COMPATIBLE_MACHINEto limit that it is only available for qemuall, or else it can be built successfully without the package connman-conf generated.Signed-off-by Li Zhou <[email protected]>--- meta/recipes-connectivity/connman/connman-conf.bb | 2 ++ meta/recipes-connectivity/connman/connman_1.38.bb | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)meta/recipes-connectivity/connman/connman-conf.bb +2
-0@@ -34,3 +34,5 @@ do_install() { } SYSTEMD_SERVICE_${PN}_qemuall = "wired-connection.service" +COMPATIBLE_MACHINE = "null" +COMPATIBLE_MACHINE_qemuall = "${MACHINE}"meta/recipes-connectivity/connman/connman_1.38.bb +0
-0@@ -12,5 +12,5 @@ SRC_URI_append_libc-musl = "file://0002-resolve-musl-does-not-implement-res_nin
SRC_URI[md5sum] = "1ed8745354c7254bdfd4def54833ee94" SRC_URI[sha256sum] =
"cb30aca97c2f79ccaed8802aa2909ac5100a3969de74c0af8a9d73b85fc4932b"meta/recipes-connectivity/connman/connman_1.38.bb +1
-2-RRECOMMENDS_${PN} = "connman-conf" +RRECOMMENDS_${PN}_qemuall = "connman-conf" RCONFLICTS_${PN} = "networkmanager" --1.9.1
I change this because we can see below in connman-conf.bb:
SUMMARY = "Connman config to setup wired interface on *qemu* machines" DESCRIPTION = "This is the ConnMan configuration to set up a Wired \
network interface for a *qemu* machine."
On non-quem machines, "bitbake connman-conf" can return successfully, but the rpm package for connman-conf can't be generated because it is null (SRC_URI_append_qemuall = ...).
At this time, our users add connman-conf in IMAGE_INSTALL list and get such error:
No match for argument: connman-conf
Error: Unable to find a match
I myself think that it will be better to report error when "bitbake connman-conf" on non-qemu machine, since connman-conf is designed only for qemu.
It will be welcomed if you have better suggestion for the solution.
Thank you.
Quoted 59 lines · Martin Jansa
Why is this an issue?
connman-conf recipe doesn't take long time to build and if you don't want to install it on target you can use BAD_RECOMMENDATIONS variable.
We're using connman-conf to configure networking on various target machines - not only on qemu*. If this is merged I'll just undo this in our layer - and that's fine, but if there are more people using connman-conf like this, then we should re-consider this commit (or at least better explain why it's needed in commit message).
On Fri, Aug 21, 2020 at 4:54 AM Li Zhou <[email protected] <mailto:[email protected]>> wrote:
connman-conf is only for qemu machines, so use COMPATIBLE_MACHINE to limit that it is only available for qemuall, or else it can be built successfully without the package connman-conf generated. Signed-off-by: Li Zhou <[email protected] <mailto:[email protected]>> --- meta/recipes-connectivity/connman/connman-conf.bb <http://connman-conf.bb> | 2 ++ meta/recipes-connectivity/connman/connman_1.38.bb <http://connman_1.38.bb> | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/recipes-connectivity/connman/connman-conf.bb <http://connman-conf.bb> b/meta/recipes-connectivity/connman/connman-conf.bb <http://connman-conf.bb> index 9a519ec..3a6c525 100644 --- a/meta/recipes-connectivity/connman/connman-conf.bb <http://connman-conf.bb> +++ b/meta/recipes-connectivity/connman/connman-conf.bb <http://connman-conf.bb> @@ -34,3 +34,5 @@ do_install() { } SYSTEMD_SERVICE_${PN}_qemuall = "wired-connection.service" +COMPATIBLE_MACHINE = "null" +COMPATIBLE_MACHINE_qemuall = "${MACHINE}" diff --git a/meta/recipes-connectivity/connman/connman_1.38.bb <http://connman_1.38.bb> b/meta/recipes-connectivity/connman/connman_1.38.bb <http://connman_1.38.bb> index 027c41e..734b8ae 100644 --- a/meta/recipes-connectivity/connman/connman_1.38.bb <http://connman_1.38.bb> +++ b/meta/recipes-connectivity/connman/connman_1.38.bb <http://connman_1.38.bb> @@ -12,5 +12,5 @@ SRC_URI_append_libc-musl = " file://0002-resolve-musl-does-not-implement-res_nin SRC_URI[md5sum] = "1ed8745354c7254bdfd4def54833ee94" SRC_URI[sha256sum] = "cb30aca97c2f79ccaed8802aa2909ac5100a3969de74c0af8a9d73b85fc4932b" -RRECOMMENDS_${PN} = "connman-conf" +RRECOMMENDS_${PN}_qemuall = "connman-conf" RCONFLICTS_${PN} = "networkmanager" -- 1.9.1
Signature · 3 lines
Best Regards! Zhou Li Phone number: 86-10-84778511
Quoted 1 line · Martin Jansa
We're using connman-conf to configure networking on various target machines - not only on qemu*. If this is merged I'll just undo this in our layer - and that's fine, but if there are more people using connman-conf like this, then we should re-consider this commit (or at least better explain why it's needed in commit message).
Same here, please don't do this.
Concrete use-case: building for a real machine (say, intel-corei7-64) that is supported by runqemu. If you want testimage to work, you need the networking configuration from connman-conf.
Ross
Quoted 9 lines · Ross Burton
Quoted 1 line · Martin Jansa
We're using connman-conf to configure networking on various target machines - not only on qemu*. If this is merged I'll just undo this in our layer - and that's fine, but if there are more people using connman-conf like this, then we should re-consider this commit (or at least better explain why it's needed in commit message).
Same here, please don't do this.
Concrete use-case: building for a real machine (say, intel-corei7-64) that is supported by runqemu. If you want testimage to work, you need the networking configuration from connman-conf.
Ross
Hi, Ross:
I have a question here:
building for a real machine (say, intel-corei7-64): MACHINE ?= intel-corei7-64
While in connman-conf.bb:SRC_URI_append_qemuall = " file://wired.config \
file://wired-setup \
file://wired-connection.service \
So there is no connman-conf package generated by default because it's null. Building error occurs if want to install connman-conf to rootfs. So how to make things work?
If I misunderstand anything, please let me know. Thanks.
Signature · 3 lines
Best Regards! Zhou Li Phone number: 86-10-84778511
Quoted 9 lines · zhou li
I have a question here:
building for a real machine (say, intel-corei7-64): MACHINE ?= intel-corei7-64While in connman-conf.bb:
SRC_URI_append_qemuall = " file://wired.config \ file://wired-setup \ file://wired-connection.service \
Quoted 5 lines
So there is no connman-conf package generated by default because it's null. Building error occurs if want to install connman-conf to rootfs. So how to make things work?
If I misunderstand anything, please let me know. Thanks.
I also have a patch to remove that _qemuall override that I've been meaning to post for a long time...
Ross
Hi, Ross:
Do you have any plan to do this patch?
I think my issue can disappear with your planned patch.
Thanks.
Quoted 20 lines · Ross Burton
Quoted 9 lines · zhou li
I have a question here:
building for a real machine (say, intel-corei7-64): MACHINE ?= intel-corei7-64While in connman-conf.bb:
SRC_URI_append_qemuall = " file://wired.config \ file://wired-setup \ file://wired-connection.service \Quoted 5 lines
So there is no connman-conf package generated by default because it's null. Building error occurs if want to install connman-conf to rootfs. So how to make things work?
If I misunderstand anything, please let me know. Thanks.
I also have a patch to remove that
_qemualloverride that I've been meaning to post for a long time...Ross
Signature · 3 lines
Best Regards! Zhou Li Phone number: 86-10-84778511