mmc: sdhci-msm: Enable restore_dll_config flag for sc7180 target
Subsystems (3)
PATCH 1/1 mmc: sdhci-msm: Enable restore_dll_config flag for sc7180 target
On sc7180 target, issues are observed with HS400 mode due to a hardware limitation. If sdcc clock is dynamically gated and ungated, the very next command is failing with command CRC/timeout errors.
To mitigate this issue, DLL phase has to be restored whenever sdcc clock is gated dynamically. The restore_dll_config ensures this. Enabling this flag with this change. And simply re-using the sdm845 target configuration for this flag.
--- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-msm.c +1 -0
@@ -2151,6 +2151,7 @@ static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sm8250-sdhci", .data = &sm8250_sdhci_var}, + {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var}, {}, };
Signature · 1 line
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Hi,
Quoted 10 lines · Veerabhadrarao Badiganti
On sc7180 target, issues are observed with HS400 mode due to a hardware limitation. If sdcc clock is dynamically gated and ungated, the very next command is failing with command CRC/timeout errors.
To mitigate this issue, DLL phase has to be restored whenever sdcc clock is gated dynamically. The
restore_dll_configensures this. Enabling this flag with this change. And simply re-using the sdm845 target configuration for this flag.
Quoted 4 lines
Signed-off-by Veerabhadrarao Badiganti <[email protected]>--- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+)
Whoops! I was too busy debugging and preparing patches and didn't realize that you'd already sent this. Sorry for sending it too. Let's take yours.
Quoted 11 lines · Veerabhadrarao Badiganti
On sc7180 target, issues are observed with HS400 mode due to a hardware limitation. If sdcc clock is dynamically gated and ungated, the very next command is failing with command CRC/timeout errors.
To mitigate this issue, DLL phase has to be restored whenever sdcc clock is gated dynamically. The
restore_dll_configensures this. Enabling this flag with this change. And simply re-using the sdm845 target configuration for this flag.Signed-off-by Veerabhadrarao Badiganti <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 19 lines
--- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+)drivers/mmc/host/sdhci-msm.c +1
-1@@ -2151,6 +2151,7 @@ static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sm8250-sdhci", .data = &sm8250_sdhci_var}, + {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var}, {}, }; --Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project