Skip to contentSkip to conversation

BUG REPORT: Missing #include statements

DISCUSSION Lars Hamren 2 participants 2 messages Mar 20, 2003 – Mar 25, 2003

lore
Share & tools
lore
#0 lore raw

Several C source files does not explicitly include the headers files they need; instead they rely on asoundlib.h to include them. Here is a list of missing includes:

    alsa-tools-0.9.0rc7/ac3dec/output.c:               # include <assert.h>
    alsa-tools-0.9.0rc7/ac3dec/output.c:               # include <alloca.h>
    alsa-tools-0.9.0rc7/ac3dec/output.c:               # include <string.h>
    alsa-tools-0.9.0rc7/ac3dec/output.c:               # include <unistd.h>
    alsa-tools-0.9.0rc7/envy24control/driverevents.c:  # include <assert.h>

    alsa-tools-0.9.0rc7/envy24control/envy24control.c: # include <assert.h>

    alsa-tools-0.9.0rc7/envy24control/hardware.c:      # include <assert.h>

    alsa-tools-0.9.0rc7/envy24control/mixer.c:         # include <assert.h>

    alsa-tools-0.9.0rc7/envy24control/patchbay.c:      # include <assert.h>

    alsa-tools-0.9.0rc7/envy24control/volume.c:        # include <assert.h>

    alsa-tools-0.9.0rc7/sb16_csp/cspctl.c:             # include <fcntl.h>
    alsa-tools-0.9.0rc7/sb16_csp/cspctl.c:             # include <unistd.h>
    alsa-tools-0.9.0rc7/sb16_csp/cspctl.c:             # include <assert.h>
    alsa-tools-0.9.0rc7/sb16_csp/cspctl.c:             # include <string.h>
    alsa-tools-0.9.0rc7/sb16_csp/cspctl.c:             # include <errno.h>

    alsa-tools-0.9.0rc7/seq/sbiload/sbiload.c:         # include <assert.h>
    alsa-tools-0.9.0rc7/seq/sbiload/sbiload.c:         # include <unistd.h>
    alsa-tools-0.9.0rc7/seq/sbiload/sbiload.c:         # include <fcntl.h>
    alsa-utils-0.9.0rc7/seq/aseqnet/aseqnet.c:         # include <assert.h>
    alsa-utils-0.9.0rc7/seq/aseqnet/aseqnet.c:         # include <errno.h>

This is not a problem for users of the standard asoundlib.h, but a problem when developing an alternative header file for a new language binding.

As I do not have CVS access, I cannot update the source.

Regards
/Lars
-------------------------------------------------------------------
Lars Hamrén Tel...: +46(46)189090
Svensk Datorutveckling e-post: [email protected]
Vadmöllan 211 WWW...: www.sdu.se
S-225 94 Lund
Sweden

-------------------------------------------------------
This SF.net email is sponsored by: Tablet PC.
Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en

#1 lore raw

Hi,

At Thu, 20 Mar 2003 17:51:55 +0100,

Quoted 5 lines · Lars Hamren

Several C source files does not explicitly include the headers files they need; instead they rely on asoundlib.h to include them. Here is a list of missing includes:

thanks for reports!

fixed on cvs now.

Takashi

-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en