Skip to contentSkip to conversation

venus: core: vote for video-mem icc path and change avg, peak bw

PATCH Superseded Mansur Alisha Shaik 2 participants 3 messages Sep 8, 2020 – Sep 17, 2020

Subsystems (4)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 venus: core: vote for video-mem icc path and change avg, peak bw

Currently we are voting for venus0-ebi path during buffer processing with an average bandwidth of all the instances and unvoting during session release.

While video streaming when we try to do XO-SD using the command "echo mem > /sys/power/state command" , device is not entering to suspend state and from interconnect summary seeing votes for venus0-ebi

Corrected this by voting for venus0-ebi path in venus_runtime_resume and unvote during venus_runtime_suspend.

---
 drivers/media/platform/qcom/venus/core.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/media/platform/qcom/venus/core.c +9 -1
index 4857bbd..79d8600 100644
@@ -373,6 +373,10 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)
 	if (ret)
 		return ret;
 
+	ret = icc_set_bw(core->video_path, 0, 0);
+	if (ret)
+		return ret;
+
 	return ret;
 }
 
@@ -382,7 +386,11 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)
 	const struct venus_pm_ops *pm_ops = core->pm_ops;
 	int ret;
 
-	ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
+	ret = icc_set_bw(core->video_path, kbps_to_icc(20000), 0);
+	if (ret)
+		return ret;
+
+	ret = icc_set_bw(core->cpucfg_path, kbps_to_icc(1000), 0);
 	if (ret)
 		return ret;
 
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

Quoting Mansur Alisha Shaik (2020-09-07 20:44:38)

Quoted 9 lines

Currently we are voting for venus0-ebi path during buffer processing with an average bandwidth of all the instances and unvoting during session release.

While video streaming when we try to do XO-SD using the command "echo mem > /sys/power/state command" , device is not entering to suspend state and from interconnect summary seeing votes for venus0-ebi

Corrected this by voting for venus0-ebi path in venus_runtime_resume

venus_runtime_resume() please so we know it's a function.

Quoted 1 line

and unvote during venus_runtime_suspend.

venus_runtime_suspend().

Quoted 3 lines

---

Any Fixes: tag?

Quoted 19 lines
 drivers/media/platform/qcom/venus/core.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/media/platform/qcom/venus/core.c +4 -0
index 4857bbd..79d8600 100644
@@ -373,6 +373,10 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)
        if (ret)
                return ret;
 
+       ret = icc_set_bw(core->video_path, 0, 0);
+       if (ret)
+               return ret;
+
        return ret;
 }
 

drivers/media/platform/qcom/venus/core.c static __maybe_unused int venus_runtime_resume(struct device *dev) · line 389

Quoted 5 lines
drivers/media/platform/qcom/venus/core.c +1 -1
@@ -382,7 +386,11 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)
        const struct venus_pm_ops *pm_ops = core->pm_ops;
        int ret;
 
-       ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
+       ret = icc_set_bw(core->video_path, kbps_to_icc(20000), 0);

This also shows that the arguments to icc_set_bw() we're backwards? Can that be fixed in another patch instead of putting it in this one?

#2 lore raw
Quoted 6 lines · Stephen Boyd
Quoted 5 lines

Quoting Mansur Alisha Shaik (2020-09-07 20:44:38)

Quoted 4 lines

Currently we are voting for venus0-ebi path during buffer processing with an average bandwidth of all the instances and unvoting during session release.

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

While video streaming when we try to do XO-SD using the command "echo mem > /sys/power/state command" , device is not entering to suspend state and from interconnect summary seeing votes for venus0-ebi

Corrected this by voting for venus0-ebi path in venus_runtime_resume

venus_runtime_resume() please so we know it's a function.

Changed to function like notation and RESEND v2
https://lore.kernel.org/patchwork/project/lkml/list/?series=463283

Quoted 10 lines
Quoted 10 lines
Quoted 2 lines

and unvote during venus_runtime_suspend.

venus_runtime_suspend().

Quoted 3 lines

---

Any Fixes: tag?

Added the Fixes tag

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
 drivers/media/platform/qcom/venus/core.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/media/platform/qcom/venus/core.c +4 -0
index 4857bbd..79d8600 100644
@@ -373,6 +373,10 @@ static __maybe_unused int 
 venus_runtime_suspend(struct device *dev)
        if (ret)
                return ret;
 
+       ret = icc_set_bw(core->video_path, 0, 0);
+       if (ret)
+               return ret;
+
        return ret;
 }
@@ -382,7 +386,11 @@ static __maybe_unused int 
 venus_runtime_resume(struct device *dev)
        const struct venus_pm_ops *pm_ops = core->pm_ops;
        int ret;
 
Quoted 5 lines
Quoted 5 lines

drivers/media/platform/qcom/venus/core.c static __maybe_unused int venus_runtime_resume(struct device *dev) · line 389

Quoted 2 lines
drivers/media/platform/qcom/venus/core.c +1 -1
-       ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
+       ret = icc_set_bw(core->video_path, kbps_to_icc(20000), 0);

This also shows that the arguments to icc_set_bw() we're backwards? Can that be fixed in another patch instead of putting it in this one?

posted as another patch set.
https://lore.kernel.org/patchwork/project/lkml/list/?series=463283