Skip to contentSkip to conversation

cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

PATCH In review Denys Dmytriyenko 2 participants 4 messages Sep 10, 2020 – Sep 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

From: Denys Dmytriyenko <[email protected]>

There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.

---
v2 - append SRCPV to PV

 meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +2 -1
index 906f4fc..027d636 100644
@@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
            "
-SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
+SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
+PV .= "+git${SRCPV}"
 
 S = "${WORKDIR}/git"
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 17 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.

---
v2 - append SRCPV to PV

 meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -0
index 906f4fc..027d636 100644

meta/recipes-kernel/cryptodev/cryptodev.inc LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" · line 9

Quoted 6 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +2 -1
@@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
            "
-SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
+SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
+PV .= "+git${SRCPV}"

I just saw that this change does not go well with some of meta-freescale changes which uses the inc file paired with PV, so perhaps keeping the version at same PV
or creating a single patch is better.

now ends up with.

ERROR: ParseError at /mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc

Quoted 7 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -1
 S = "${WORKDIR}/git"
 
--

2.7.4

#2 lore raw
Quoted 19 lines · Khem Raj
Quoted 18 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.

---
v2 - append SRCPV to PV

 meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -0
index 906f4fc..027d636 100644
@@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
Quoted 10 lines

meta/recipes-kernel/cryptodev/cryptodev.inc LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" · line 9

Quoted 5 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +2 -1
 SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
            "
-SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
+SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
+PV .= "+git${SRCPV}"

I just saw that this change does not go well with some of meta-freescale changes which uses the inc file paired with PV, so perhaps keeping the version at same PV
or creating a single patch is better.

Well, it's unfortunate that it affects some downstream layers, but that never stopped changes in OE-Core before - as a maintainer of few downstream layers myself, I had to adapt to such changes in the past many-many times...

Anyway, alternative would be to use v1 of the patch.

Quoted 15 lines

now ends up with.

ERROR: ParseError at /mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc

Quoted 7 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -1
 S = "${WORKDIR}/git"
 
--

2.7.4

#3 lore raw
Quoted 31 lines · Denys Dmytriyenko
Quoted 19 lines · Khem Raj
Quoted 18 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.

---
v2 - append SRCPV to PV

  meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -0
index 906f4fc..027d636 100644
@@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
Quoted 10 lines

meta/recipes-kernel/cryptodev/cryptodev.inc LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" · line 9

Quoted 5 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +2 -1
  SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
             "
-SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
+SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
+PV .= "+git${SRCPV}"

I just saw that this change does not go well with some of meta-freescale changes which uses the inc file paired with PV, so perhaps keeping the version at same PV
or creating a single patch is better.

Quoted 5 lines

Well, it's unfortunate that it affects some downstream layers, but that never stopped changes in OE-Core before - as a maintainer of few downstream layers myself, I had to adapt to such changes in the past many-many times...

Anyway, alternative would be to use v1 of the patch.

Richard

yeah lets go with v1

Quoted 17 lines
Quoted 17 lines

now ends up with.

ERROR: ParseError at /mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc

Quoted 7 lines
meta/recipes-kernel/cryptodev/cryptodev.inc +0 -1
  S = "${WORKDIR}/git"
 
--

2.7.4