iio: adc: stm32: Fix missing return in booster error path
PATCH 1/1 iio: adc: stm32: Fix missing return in booster error path
Conversion of error paths to dev_err_probe() dropped one return statement. The driver will continue to probe if getting booster regulator fails.
Reported-by Stephen Rothwell <[email protected]>
Fixes ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
Commit sha from linux-next.
--- drivers/iio/adc/stm32-adc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/stm32-adc-core.c +1 -1
@@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,if (IS_ERR (priv->booster)) { ret =PTR_ERR (priv->booster);if (ret != -ENODEV ) -dev_err_probe (dev, ret,"can't get booster\n" ); +return dev_err_probe (dev, ret,"can't get booster\n" ); priv->booster =NULL ; }
Signature · 1 line
2.7.4
Jonathan Cameron
maintainerQuoted 7 lines · On Thu, 10 Sep 2020 10:52:07 +0200 Krzysztof Kozlowski <[email protected]> wrote:
Conversion of error paths to
dev_err_probe()dropped one return statement. The driver will continue to probe if getting booster regulator fails.Reported-by Stephen Rothwell <[email protected]>Fixes ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it.
Thanks,
Jonathan
Quoted 4 lines
---
Commit sha from linux-next.
This is applying to an (in theory) non rebasing tree, so hopefully that will remain stable!
Quoted 17 lines
--- drivers/iio/adc/stm32-adc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/stm32-adc-core.c +1
-1@@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,if (IS_ERR (priv->booster)) { ret =PTR_ERR (priv->booster);if (ret != -ENODEV ) -dev_err_probe (dev, ret,"can't get booster\n" ); +return dev_err_probe (dev, ret,"can't get booster\n" ); priv->booster =NULL ; }