input: iqs62x-keys: Remove superfluous function parameter
Subsystems (2)
Dmitry Torokhov
maintainerHi Jeff,
Quoted 2 lines · Jeff LaBundy
It is not necessary to pass
iqs62x_keystoiqs62x_keys_parse_prop, because it can already be derived from theplatform_devicecookie.
Yes, it can be derived, but why is better to have it derived rather than passed in? Is the code smaller this way?
Quoted 34 lines
Signed-off-by Jeff LaBundy <[email protected]>--- drivers/input/keyboard/iqs62x-keys.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/input/keyboard/iqs62x-keys.c +3
-3@@ -42,9 +42,9 @@ struct iqs62x_keys_private {u8 interval; }; -static int iqs62x_keys_parse_prop (struct platform_device *pdev, -struct iqs62x_keys_private *iqs62x_keys) +static int iqs62x_keys_parse_prop (struct platform_device *pdev) { +struct iqs62x_keys_private *iqs62x_keys =platform_get_drvdata (pdev);struct fwnode_handle *child;unsigned int val;int ret, i;@@ -258,7 +258,7 @@ static int iqs62x_keys_probe(struct platform_device *pdev)platform_set_drvdata (pdev, iqs62x_keys); - ret =iqs62x_keys_parse_prop (pdev, iqs62x_keys); + ret =iqs62x_keys_parse_prop (pdev);if (ret)return ret;Signature · 1 line
2.7.4
Thanks.
Signature · 1 line
Dmitry
Hi Dmitry,
Thanks for taking a look.
Quoted 9 lines · Dmitry Torokhov
Hi Jeff,
Quoted 2 lines · Jeff LaBundy
It is not necessary to pass
iqs62x_keystoiqs62x_keys_parse_prop, because it can already be derived from theplatform_devicecookie.Yes, it can be derived, but why is better to have it derived rather than passed in? Is the code smaller this way?
I think it is better practice to limit the function's parameters to only those that are minimally necessary. In this particular case we only want to populate data in the same iqs62x_keys struct that was allocated using the original pdev->dev instance, so it seems safer to enforce this by only offering a single parameter instead of allowing them to be separate.
That's all but guaranteed not to be a problem in this driver; it simply caught my attention while re-using this code in another project. I would be happy to add more details in the commit message, but it is also fine for this patch to be dropped if you prefer.
Quoted 31 lines
Quoted 31 lines
Signed-off-by Jeff LaBundy <[email protected]>--- drivers/input/keyboard/iqs62x-keys.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/input/keyboard/iqs62x-keys.c +3
-3@@ -42,9 +42,9 @@ struct iqs62x_keys_private {u8 interval; }; -static int iqs62x_keys_parse_prop (struct platform_device *pdev, -struct iqs62x_keys_private *iqs62x_keys) +static int iqs62x_keys_parse_prop (struct platform_device *pdev) { +struct iqs62x_keys_private *iqs62x_keys =platform_get_drvdata (pdev);struct fwnode_handle *child;unsigned int val;int ret, i;@@ -258,7 +258,7 @@ static int iqs62x_keys_probe(struct platform_device *pdev)platform_set_drvdata (pdev, iqs62x_keys); - ret =iqs62x_keys_parse_prop (pdev, iqs62x_keys); + ret =iqs62x_keys_parse_prop (pdev);if (ret)return ret;
Quoted 8 lines
Quoted 3 lines
Signature · 1 line
2.7.4Thanks.
Signature · 1 line
Dmitry
Kind regards,
Jeff LaBundy
PATCH RESEND 1/1 input: iqs62x-keys: Remove superfluous function parameter
It is not necessary to pass iqs62x_keys to iqs62x_keys_parse_prop, because it can already be derived from the platform_device cookie.
--- drivers/input/keyboard/iqs62x-keys.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/input/keyboard/iqs62x-keys.c +3 -3
@@ -42,9 +42,9 @@ struct iqs62x_keys_private {u8 interval; }; -static int iqs62x_keys_parse_prop (struct platform_device *pdev, -struct iqs62x_keys_private *iqs62x_keys) +static int iqs62x_keys_parse_prop (struct platform_device *pdev) { +struct iqs62x_keys_private *iqs62x_keys =platform_get_drvdata (pdev);struct fwnode_handle *child;unsigned int val;int ret, i;
@@ -258,7 +258,7 @@ static int iqs62x_keys_probe(struct platform_device *pdev)platform_set_drvdata (pdev, iqs62x_keys); - ret =iqs62x_keys_parse_prop (pdev, iqs62x_keys); + ret =iqs62x_keys_parse_prop (pdev);if (ret)return ret;
Signature · 1 line
2.7.4