Skip to contentSkip to conversation

splash: Use splashfile instead of location->name

PATCH Superseded Jonas Mark (BT-FIR/ENG1) 1 participant 1 message Feb 4, 2019

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 splash: Use splashfile instead of location->name

Hi Simon,

thank you for your review.

Quoted 7 lines
Quoted 7 lines
doc/README.splashprepare +0 -0
index f1418de..c7f7493 100644
@@ -26,6 +26,6 @@ screen data is loaded as a file. The name of the splash screen file can be

  controlled with the environment variable "splashfile".

Quoted 9 lines

doc/README.splashprepare

Quoted 7 lines

  To enable loading the splash image from a FIT image, CONFIG_FIT must be

doc/README.splashprepare +3 -3
-enabled. Struct splash_location field 'name' should match the splash image
-name within the FIT and the FIT should start at the 'offset' field address in
-the specified storage.
+enabled. The FIT image has to start at the 'offset' field address in the
+selected splash location. The name of splash image within the FIT shall be
+specified by the environment variable "splashfile".

Can you also mention the default name?

Good proposal, we will do that.

I will wait if there is more feedback and then send an updated patch set.

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1)
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster