ath11k: fix undefined reference to 'ath11k_debugfs_htt_ext_stats_handler'
PATCH 1/1 ath11k: fix undefined reference to 'ath11k_debugfs_htt_ext_stats_handler'
kbuild bot reported than link fails when CONFIG_ATH11K_DEBUGFS is disabled:
drivers/net/wireless/ath/ath11k/dp_rx.c:1662: undefined reference to `ath11k_debugfs_htt_ext_stats_handler'
This was because I had missed to move the static inline version of the function (which are used when CONFIG_ATH11K_DEBUGFS is disabled) to debufs_htt_stats.h. Also move ath11k_debugfs_htt_stats_req() at the same time. And create a stub also for ath11k_debugfs_htt_stats_init() for consistency, even if it's not needed.
--- drivers/net/wireless/ath/ath11k/debugfs.h | 10 ---------- drivers/net/wireless/ath/ath11k/debugfs_htt_stats.h | 20 ++++++++++++++++++++ 2 files changed, 20 insertions(+), 10 deletions(-)
drivers/net/wireless/ath/ath11k/debugfs.h +0 -10
@@ -173,11 +173,6 @@ static inline void ath11k_debugfs_unregister(struct ath11k *ar) { } -static inline void ath11k_dbg_htt_ext_stats_handler (struct ath11k_base *ab, -struct sk_buff *skb) -{ -} -static inline void ath11k_debugfs_fw_stats_process (struct ath11k_base *ab,struct sk_buff *skb) {
@@ -197,11 +192,6 @@ static inline int ath11k_debugfs_is_extd_rx_stats_enabled(struct ath11k *ar)return 0 ; } -static inline int ath11k_debugfs_htt_stats_req (struct ath11k *ar) -{ -return 0 ; -} -static inline bool ath11k_debugfs_is_pktlog_lite_mode_enabled (struct ath11k *ar) {return false;
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.h +20 -0
@@ -1685,9 +1685,29 @@ struct htt_ring_backpressure_stats_tlv { u32 backpressure_hist[5]; }; +#ifdef CONFIG_ATH11K_DEBUGFS +void ath11k_debugfs_htt_stats_init (struct ath11k *ar);void ath11k_debugfs_htt_ext_stats_handler (struct ath11k_base *ab,struct sk_buff *skb);int ath11k_debugfs_htt_stats_req (struct ath11k *ar); +#else /* CONFIG_ATH11K_DEBUGFS */ + +static inline void ath11k_debugfs_htt_stats_init (struct ath11k *ar) +{ +} + +static inline void ath11k_debugfs_htt_ext_stats_handler (struct ath11k_base *ab, +struct sk_buff *skb) +{ +} + +static inline int ath11k_debugfs_htt_stats_req (struct ath11k *ar) +{ +return 0 ; +} + +#endif /* CONFIG_ATH11K_DEBUGFS */ +#endif
Signature · 7 lines
2.7.4 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 10 lines · Kalle Valo
kbuild bot reported than link fails when
CONFIG_ATH11K_DEBUGFSis disabled:
drivers/net/wireless/ath/ath11k/dp_rx.c:1662: undefined reference to `ath11k_debugfs_htt_ext_stats_handler'This was because I had missed to move the static inline version of the function (which are used when
CONFIG_ATH11K_DEBUGFSis disabled) todebufs_htt_stats.h. Also moveath11k_debugfs_htt_stats_req()at the same time. And create a stub also forath11k_debugfs_htt_stats_init()for consistency, even if it's not needed.
Quoted 3 lines
Reported-by kernel test robot <[email protected]>Fixes 568f06036ee2 ("ath11k: debugfs: move some function declarations to correct header files")Signed-off-by Kalle Valo <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
bc8befe6f950 ath11k: fix undefined reference to 'ath11k_debugfs_htt_ext_stats_handler'
Signature · 3 lines
https://patchwork.kernel.org/patch/11799379/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 10 lines · Kalle Valo
kbuild bot reported than link fails when
CONFIG_ATH11K_DEBUGFSis disabled:
drivers/net/wireless/ath/ath11k/dp_rx.c:1662: undefined reference to `ath11k_debugfs_htt_ext_stats_handler'This was because I had missed to move the static inline version of the function (which are used when
CONFIG_ATH11K_DEBUGFSis disabled) todebufs_htt_stats.h. Also moveath11k_debugfs_htt_stats_req()at the same time. And create a stub also forath11k_debugfs_htt_stats_init()for consistency, even if it's not needed.
Quoted 3 lines
Reported-by kernel test robot <[email protected]>Fixes 568f06036ee2 ("ath11k: debugfs: move some function declarations to correct header files")Signed-off-by Kalle Valo <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
bc8befe6f950 ath11k: fix undefined reference to 'ath11k_debugfs_htt_ext_stats_handler'
Signature · 9 lines
https://patchwork.kernel.org/patch/11799379/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k