Skip to contentSkip to conversation

kprobes: Correct a type error in function kprobes_module_callback

PATCH Superseded Zhouyi Zhou 2 participants 3 messages Oct 8, 2020 kprobes

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kprobes: Correct a type error in function kprobes_module_callback

There is a tiny type error in comment of function kprobes_module_callback.

---
 kernel/kprobes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/kprobes.c +1 -1
index e995541..9d2042b 100644
@@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
 			     within_module_core((unsigned long)p->addr, mod))) {
 				/*
 				 * The vaddr this probe is installed will soon
-				 * be vfreed buy not synced to disk. Hence,
+				 * be vfreed but not synced to disk. Hence,
 				 * disarming the breakpoint isn't needed.
 				 *
 				 * Note, this will also move any optimized probes
Signature · 1 line
1.7.1
#1 lore raw

Hi,

Quoted 1 line · Zhouyi Zhou

There is a tiny type error in comment of function kprobes_module_callback.

Preferable
typo
and same in $Subject.

'type' usually means data type or maybe typedef, or even font or typeface.

I suppose you could say a "typing" error (as in using a typewriter or keyboard).

Quoted 12 lines
---
 kernel/kprobes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/kprobes.c +0 -0
index e995541..9d2042b 100644

kernel/kprobes.c static int kprobes_module_callback(struct notifier_block *nb, · line 2438

Quoted 8 lines
kernel/kprobes.c +1 -1
@@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
 			     within_module_core((unsigned long)p->addr, mod))) {
 				/*
 				 * The vaddr this probe is installed will soon
-				 * be vfreed buy not synced to disk. Hence,
+				 * be vfreed but not synced to disk. Hence,
 				 * disarming the breakpoint isn't needed.
 				 *
 				 * Note, this will also move any optimized probes

thanks.

Signature · 1 line
~Randy
#2 lore raw

Thanks for the tip!

Quoted 41 lines · Randy Dunlap

Hi,

Quoted 1 line · Zhouyi Zhou

There is a tiny type error in comment of function kprobes_module_callback.

Preferable
typo
and same in $Subject.

'type' usually means data type or maybe typedef, or even font or typeface.

I suppose you could say a "typing" error (as in using a typewriter or keyboard).

Quoted 12 lines
---
 kernel/kprobes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/kprobes.c +0 -0
index e995541..9d2042b 100644

kernel/kprobes.c static int kprobes_module_callback(struct notifier_block *nb, · line 2438

Quoted 8 lines
kernel/kprobes.c +1 -1
@@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
                           within_module_core((unsigned long)p->addr, mod))) {
                              /*
                               * The vaddr this probe is installed will soon
-                              * be vfreed buy not synced to disk. Hence,
+                              * be vfreed but not synced to disk. Hence,
                               * disarming the breakpoint isn't needed.
                               *
                               * Note, this will also move any optimized probes

thanks.
--
~Randy