Patch "mtd: rawnand: sunxi: Fix the probe error path" has been added to the 4.4-stable tree

DISCUSSION Nobuhiro Iwamatsu 2 participants 2 messages Oct 10, 2020 – Oct 11, 2020 1 message not in the archive Stable branch

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Nobuhiro Iwamatsu

author

2020-10-10 23:28 UTC #1 lore raw

Hi,

Quoted 8 lines · On Fri, Oct 09, 2020 at 04:02:29PM +0200, [email protected] wrote:

This is a note to let you know that I've just added the patch titled
mtd: rawnand: sunxi: Fix the probe error path
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
mtd-rawnand-sunxi-fix-the-probe-error-path.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

This patch content is not sufficient for 4.4.y.
4.4.y does not provide nand_cleanup(), which results in a build error.

Please drop this from 4.4.y queue.

Best regards,
Nobuhiro

Quoted 42 lines

Quoted 3 lines
From 3d84515ffd8fb657e10fa5b1215e9f095fa7efca Mon Sep 17 00:00:00 2001
From: Miquel Raynal <[email protected]>
Date: Tue, 19 May 2020 15:00:26 +0200
Subject: mtd: rawnand: sunxi: Fix the probe error path
From: Miquel Raynal <[email protected]>
commit 3d84515ffd8fb657e10fa5b1215e9f095fa7efca upstream.
nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead.
Fixes 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support")
Signed-off-by Miquel Raynal <[email protected]>
Cc [email protected]
Link https://lore.kernel.org/linux-mtd/[email protected] open here
[iwamatsu: adjust filename]
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 drivers/mtd/nand/sunxi_nand.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/sunxi_nand.c +1 -1
@@ -1376,7 +1376,7 @@ static int sunxi_nand_chip_init(struct d
 	ret = mtd_device_parse_register(mtd, NULL, &ppdata, NULL, 0);
 	if (ret) {
 		dev_err(dev, "failed to register mtd device: %d\n", ret);
-		nand_release(mtd);
+		nand_cleanup(mtd);
 		return ret;
 	}
 
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/mtd-rawnand-sunxi-fix-the-probe-error-path.patch

Greg KH

maintainer

2020-10-11 08:37 UTC #2 lore raw

Quoted 15 lines · Nobuhiro Iwamatsu

Hi,
Quoted 12 lines · On Fri, Oct 09, 2020 at 04:02:29PM +0200, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
mtd: rawnand: sunxi: Fix the probe error path
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mtd-rawnand-sunxi-fix-the-probe-error-path.patch
and it can be found in the queue-4.4 subdirectory.

Quoted 8 lines

Quoted 2 lines
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
This patch content is not sufficient for 4.4.y.
4.4.y does not provide nand_cleanup(), which results in a build error.
Please drop this from 4.4.y queue.

Ah, good catch, sorry about that, now dropped.

greg k-h