Skip to contentSkip to conversation

riscv: fix pfn_to_virt err in do_page_fault().

PATCH In review liush 2 participants 4 messages Oct 26, 2020 – Oct 28, 2020 RISC-V

lore
Share & tools
lore

liush

author
#0 lore raw

PATCH v4 1/1 riscv: fix pfn_to_virt err in do_page_fault().

From: Shaohua Liu <[email protected]>

The argument to pfn_to_virt() should be pfn not the value of CSR_SATP.

---
 arch/riscv/mm/fault.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/riscv/mm/fault.c +3 -1
index 1359e21..3c8b9e4 100644
@@ -86,6 +86,7 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	pmd_t *pmd, *pmd_k;
 	pte_t *pte_k;
 	int index;
+	unsigned long pfn;
 
 	/* User mode accesses just cause a SIGSEGV */
 	if (user_mode(regs))
@@ -100,7 +101,8 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	 * of a task switch.
 	 */
 	index = pgd_index(addr);
-	pgd = (pgd_t *)pfn_to_virt(csr_read(CSR_SATP)) + index;
+	pfn = csr_read(CSR_SATP) & SATP_PPN;
+	pgd = (pgd_t *)pfn_to_virt(pfn) + index;
 	pgd_k = init_mm.pgd + index;
 
 	if (!pgd_present(*pgd_k)) {
Signature · 1 line
2.7.4
#1 lore raw

have you seen the main line?

it already corrected.

Quoted 35 lines · liush

From: Shaohua Liu <[email protected]>

The argument to pfn_to_virt() should be pfn not the value of CSR_SATP.

---
 arch/riscv/mm/fault.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/riscv/mm/fault.c +3 -1
index 1359e21..3c8b9e4 100644
@@ -86,6 +86,7 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	pmd_t *pmd, *pmd_k;
 	pte_t *pte_k;
 	int index;
+	unsigned long pfn;
 
 	/* User mode accesses just cause a SIGSEGV */
 	if (user_mode(regs))
@@ -100,7 +101,8 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	 * of a task switch.
 	 */
 	index = pgd_index(addr);
-	pgd = (pgd_t *)pfn_to_virt(csr_read(CSR_SATP)) + index;
+	pfn = csr_read(CSR_SATP) & SATP_PPN;
+	pgd = (pgd_t *)pfn_to_virt(pfn) + index;
 	pgd_k = init_mm.pgd + index;
 
 	if (!pgd_present(*pgd_k)) {
Signature · 1 line
2.7.4
Signature · 1 line
Nimflorie frostades seda!
#2 lore raw

Shaohua:
sorry, i read it wrong. this patch is right.

Quoted 37 lines · fuyao

have you seen the main line?

it already corrected.

Quoted 32 lines · liush

From: Shaohua Liu <[email protected]>

The argument to pfn_to_virt() should be pfn not the value of CSR_SATP.

---
 arch/riscv/mm/fault.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/riscv/mm/fault.c +3 -1
index 1359e21..3c8b9e4 100644
@@ -86,6 +86,7 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	pmd_t *pmd, *pmd_k;
 	pte_t *pte_k;
 	int index;
+	unsigned long pfn;
 
 	/* User mode accesses just cause a SIGSEGV */
 	if (user_mode(regs))
@@ -100,7 +101,8 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	 * of a task switch.
 	 */
 	index = pgd_index(addr);
-	pgd = (pgd_t *)pfn_to_virt(csr_read(CSR_SATP)) + index;
+	pfn = csr_read(CSR_SATP) & SATP_PPN;
+	pgd = (pgd_t *)pfn_to_virt(pfn) + index;
 	pgd_k = init_mm.pgd + index;
 
Quoted 1 line

arch/riscv/mm/fault.c static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a · line 108

Quoted 1 line
arch/riscv/mm/fault.c +0 -0
 	if (!pgd_present(*pgd_k)) {

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#3 lore raw

Shaohua:
sorry, i read it wrong. this patch is right.

Quoted 37 lines · fuyao

have you seen the main line?

it already corrected.

Quoted 32 lines · liush

From: Shaohua Liu <[email protected]>

The argument to pfn_to_virt() should be pfn not the value of CSR_SATP.

---
 arch/riscv/mm/fault.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/riscv/mm/fault.c +3 -1
index 1359e21..3c8b9e4 100644
@@ -86,6 +86,7 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	pmd_t *pmd, *pmd_k;
 	pte_t *pte_k;
 	int index;
+	unsigned long pfn;
 
 	/* User mode accesses just cause a SIGSEGV */
 	if (user_mode(regs))
@@ -100,7 +101,8 @@ static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a
 	 * of a task switch.
 	 */
 	index = pgd_index(addr);
-	pgd = (pgd_t *)pfn_to_virt(csr_read(CSR_SATP)) + index;
+	pfn = csr_read(CSR_SATP) & SATP_PPN;
+	pgd = (pgd_t *)pfn_to_virt(pfn) + index;
 	pgd_k = init_mm.pgd + index;
 
Quoted 1 line

arch/riscv/mm/fault.c static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long a · line 108

Quoted 1 line
arch/riscv/mm/fault.c +0 -0
 	if (!pgd_present(*pgd_k)) {

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv