Skip to contentSkip to conversation

eventdev: increase MAX QUEUES PER DEV to 255

PATCH Applied Timothy McDaniel 3 participants 5 messages Oct 26, 2020 – Oct 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eventdev: increase MAX QUEUES PER DEV to 255

DLB supports a total of 256 queues, 128 load balanced queues and 128 directed queues.

---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
config/rte_config.h +1 -1
index 8aa46a1..b78c6aa 100644
@@ -71,7 +71,7 @@
 
 /* eventdev defines */
 #define RTE_EVENT_MAX_DEVS 16
-#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
+#define RTE_EVENT_MAX_QUEUES_PER_DEV 255
 #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
Signature · 1 line
2.6.4
#1 lore raw
Quoted 14 lines · Timothy McDaniel

DLB supports a total of 256 queues, 128 load balanced queues and 128 directed queues.

---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
config/rte_config.h +0 -0
index 8aa46a1..b78c6aa 100644

config/rte_config.h line 74

Quoted 5 lines
config/rte_config.h +1 -1
@@ -71,7 +71,7 @@
 
 /* eventdev defines */
 #define RTE_EVENT_MAX_DEVS 16
-#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
+#define RTE_EVENT_MAX_QUEUES_PER_DEV 255

If it is 0..255 then this value should be 256. Isn't it?

Quoted 6 lines
config/rte_config.h +0 -1
 #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
--

2.6.4

#2 lore raw
Quoted 30 lines

-----Original Message-----
From: Jerin Jacob <[email protected]>
Sent: Wednesday, October 28, 2020 4:36 AM
To: McDaniel, Timothy <[email protected]>
Cc: Richardson, Bruce <[email protected]>; dpdk-dev <[email protected]>; Carrillo, Erik G <[email protected]>; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; Jerin Jacob <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255

Quoted 15 lines · Timothy McDaniel

DLB supports a total of 256 queues, 128 load balanced queues and 128 directed queues.

---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
config/rte_config.h +0 -0
index 8aa46a1..b78c6aa 100644
@@ -71,7 +71,7 @@
 
Quoted 7 lines

config/rte_config.h line 74

Quoted 4 lines
config/rte_config.h +1 -1
 /* eventdev defines */
 #define RTE_EVENT_MAX_DEVS 16
-#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
+#define RTE_EVENT_MAX_QUEUES_PER_DEV 255

If it is 0..255 then this value should be 256. Isn't it?

.max_event_queues is a uint8_t, so we could not go to 256 without changing the data structure.

Quoted 7 lines
Quoted 7 lines
config/rte_config.h +0 -1
 #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
--

2.6.4

Reviewed-by on v1 1/1
#3 lore raw
In reply to Timothy McDaniel
Quoted 11 lines

-----Original Message-----
From: McDaniel, Timothy <[email protected]>
Sent: Monday, October 26, 2020 11:01 AM
To: Richardson, Bruce <[email protected]>
Cc: [email protected]; Carrillo, Erik G <[email protected]>; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; [email protected]
Subject: [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255

Quoted 4 lines

DLB supports a total of 256 queues, 128 load balanced queues and 128 directed queues.

Perhaps you can increase the queues-related fields to uint16_t in the future to allow for the full 256, but in the meantime:

Thanks,
Gage

Acked-by Reviewed-by Gage Eads Acked-by Applied
#4 lore raw
Quoted 15 lines · Gage
Quoted 15 lines

-----Original Message-----
From: McDaniel, Timothy <[email protected]>
Sent: Monday, October 26, 2020 11:01 AM
To: Richardson, Bruce <[email protected]>
Cc: [email protected]; Carrillo, Erik G <[email protected]>; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; [email protected]
Subject: [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255

DLB supports a total of 256 queues, 128 load balanced queues and 128 directed queues.

Quoted 6 lines
Quoted 1 line

Perhaps you can increase the queues-related fields to uint16_t in the future to allow for the full 256, but in the meantime:

Applied to dpdk-next-eventdev/for-main with following git commit change, Thanks.

commit e79fdca1baaff30cbdd423b1fec82087cafc0b83 (HEAD -> for-main, origin/for-main, origin/HEAD)

Author: Timothy McDaniel <[email protected]>
Date:   Mon Oct 26 11:01:08 2020 -0500

eventdev: increase max queues configuration

DLB supports a total of 256 queues, 128 load balanced queues and 128 directed queues. Increase RTE_EVENT_MAX_QUEUES_PER_DEV to max possible uint_8_t max value.

Quoted 3 lines

Thanks,
Gage