Skip to contentSkip to conversation

net/mlx5: fix Tx queue start

PATCH In review Matan Azrad 2 participants 2 messages Oct 27, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix Tx queue start

The Tx queue stop\start operations update the HW state of the Tx queue object. The stop API should update the state from ready to reset in order to stop any queue traffic and the start API should update the state from reset to ready in order to open the traffic path.

The start API wrongly tried to change the state from ready to ready what caused a failure in FW on the current state validation.

Replace ready to ready command by reset to ready command in the Tx start API.

Fixes 161d103b231c ("net/mlx5: add queue start and stop")
---
 drivers/net/mlx5/mlx5.h     | 1 -
 drivers/net/mlx5/mlx5_txq.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/net/mlx5/mlx5.h +0 -1
index 7429811..0902628 100644
@@ -788,7 +788,6 @@ enum mlx5_rxq_modify_type {
 };
 
 enum mlx5_txq_modify_type {
-	MLX5_TXQ_MOD_RDY2RDY, /* modify state from ready to ready. */
 	MLX5_TXQ_MOD_RST2RDY, /* modify state from reset to ready. */
 	MLX5_TXQ_MOD_RDY2RST, /* modify state from ready to reset. */
 	MLX5_TXQ_MOD_ERR2RDY, /* modify state from error to ready. */
drivers/net/mlx5/mlx5_txq.c +1 -1
index dca9c05..605cbfc 100644
@@ -253,7 +253,7 @@
 
 	MLX5_ASSERT(rte_eal_process_type() ==  RTE_PROC_PRIMARY);
 	ret = priv->obj_ops.txq_obj_modify(txq_ctrl->obj,
-					   MLX5_TXQ_MOD_RDY2RDY,
+					   MLX5_TXQ_MOD_RST2RDY,
 					   (uint8_t)priv->dev_port);
 	if (ret)
 		return ret;
Signature · 1 line
1.8.3.1
#1 lore raw

Hi,

Quoted 55 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Matan Azrad
Sent: Tuesday, October 27, 2020 8:43 AM
To: Slava Ovsiienko <[email protected]>
Cc: [email protected]; [email protected]
Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue start

The Tx queue stop\start operations update the HW state of the Tx queue object. The stop API should update the state from ready to reset in order to stop any queue traffic and the start API should update the state from reset to ready in order to open the traffic path.

The start API wrongly tried to change the state from ready to ready what caused a failure in FW on the current state validation.

Replace ready to ready command by reset to ready command in the Tx start API.

Fixes 161d103b231c ("net/mlx5: add queue start and stop")
---
 drivers/net/mlx5/mlx5.h     | 1 -
 drivers/net/mlx5/mlx5_txq.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/net/mlx5/mlx5.h +0 -1
index 7429811..0902628 100644
@@ -788,7 +788,6 @@ enum mlx5_rxq_modify_type {
 };
 
 enum mlx5_txq_modify_type {
-	MLX5_TXQ_MOD_RDY2RDY, /* modify state from ready to ready. */
 	MLX5_TXQ_MOD_RST2RDY, /* modify state from reset to ready. */
 	MLX5_TXQ_MOD_RDY2RST, /* modify state from ready to reset. */
 	MLX5_TXQ_MOD_ERR2RDY, /* modify state from error to ready. */
drivers/net/mlx5/mlx5_txq.c +1 -2
index dca9c05..605cbfc 100644
@@ -253,7 +253,7 @@
 
 	MLX5_ASSERT(rte_eal_process_type() ==  RTE_PROC_PRIMARY);
 	ret = priv->obj_ops.txq_obj_modify(txq_ctrl->obj,
-					   MLX5_TXQ_MOD_RDY2RDY,
+					   MLX5_TXQ_MOD_RST2RDY,
 					   (uint8_t)priv->dev_port);
 	if (ret)
 		return ret;
--
Quoted 1 line

1.8.3.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh