drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
Subsystems (2)
PATCH 1/1 drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
From: Lina Iyer <[email protected]>
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler.
A write_tcs_reg_sync() would read back the value that is written and try to match it to the value written to ensure that the value is written, but if that value is different, we may see false error for same.
--- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/rpmh-rsc.c +1 -1
@@ -364,7 +364,7 @@ static void __tcs_set_trigger(struct rsc_drv *drv, int tcs_id, bool trigger) enable =TCS_AMC_MODE_ENABLE ;write_tcs_reg_sync (drv,RSC_DRV_CONTROL , tcs_id, enable); enable |=TCS_AMC_MODE_TRIGGER ; -write_tcs_reg_sync (drv,RSC_DRV_CONTROL , tcs_id, enable); +write_tcs_reg (drv,RSC_DRV_CONTROL , tcs_id, enable); } }
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Hi,
Quoted 12 lines · Maulik Shah
From: Lina Iyer <[email protected]>
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler.
A
write_tcs_reg_sync()would read back the value that is written and try to match it to the value written to ensure that the value is written, but if that value is different, we may see false error for same.
Quoted 5 lines
Signed-off-by Lina Iyer <[email protected]>Signed-off-by Maulik Shah <[email protected]>--- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
QCOM SoCs")
Doug Anderson
Reviewed-byHi,
Quoted 22 lines · Doug Anderson
Hi,
Quoted 12 lines · Maulik Shah
From: Lina Iyer <[email protected]>
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler.
A
write_tcs_reg_sync()would read back the value that is written and try to match it to the value written to ensure that the value is written, but if that value is different, we may see false error for same.Quoted 5 lines
Signed-off-by Lina Iyer <[email protected]>Signed-off-by Maulik Shah <[email protected]>--- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 3 lines
Fixes 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller forQCOM SoCs")
Signed-off-by Douglas Anderson <[email protected]>
Ugh, brain-fart. Not Signed-off-by, but:
Hi Doug,
Quoted 22 lines · Doug Anderson
Hi,
Quoted 19 lines · Doug Anderson
Hi,
Quoted 16 lines · Maulik Shah
From: Lina Iyer <[email protected]>
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler.
A
write_tcs_reg_sync()would read back the value that is written and try to match it to the value written to ensure that the value is written, but if that value is different, we may see false error for same.Signed-off-by Lina Iyer <[email protected]>Signed-off-by Maulik Shah <[email protected]>--- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines
Quoted 3 lines
Fixes 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller forQCOM SoCs")
Signed-off-by Douglas Anderson <[email protected]>Ugh, brain-fart. Not Signed-off-by, but:
Reviewed-by Douglas Anderson <[email protected]>
Thanks for the review, i will send v2 adding Fixes: tag.
Thanks,
Maulik
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation