ath11k: Ignore resetting peer auth flag in peer assoc cmd
PATCH 1/1 ath11k: Ignore resetting peer auth flag in peer assoc cmd
Incase of hardware encryption, WMI_PEER_AUTH flag will be set by firmware during install key. Since install key wont be done for software encryption mode, firmware will not set this flag. Due to this, seeing traffic failure in software encryption. Hence, avoid resetting peer auth flag if hardware encryption disabled.
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01421-QCAHKSWPL_SILICONZ-1
--- drivers/net/wireless/ath/ath11k/wmi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.c +7 -3
@@ -1686,7 +1686,8 @@ int ath11k_wmi_vdev_install_key(struct ath11k *ar,static inline void ath11k_wmi_copy_peer_flags (struct wmi_peer_assoc_complete_cmd *cmd, -struct peer_assoc_params *param) +struct peer_assoc_params *param, +bool hw_crypto_disabled) { cmd->peer_flags =0 ;
@@ -1740,7 +1741,8 @@ ath11k_wmi_copy_peer_flags(struct wmi_peer_assoc_complete_cmd *cmd, cmd->peer_flags |=WMI_PEER_AUTH ;if (param->need_ptk_4_way) { cmd->peer_flags |=WMI_PEER_NEED_PTK_4_WAY ; - cmd->peer_flags &= ~WMI_PEER_AUTH ; +if (!hw_crypto_disabled) + cmd->peer_flags &= ~WMI_PEER_AUTH ; }if (param->need_gtk_2_way) cmd->peer_flags |=WMI_PEER_NEED_GTK_2_WAY ;
@@ -1807,7 +1809,9 @@ int ath11k_wmi_send_peer_assoc_cmd(struct ath11k *ar, cmd->peer_new_assoc = param->peer_new_assoc; cmd->peer_associd = param->peer_associd; -ath11k_wmi_copy_peer_flags (cmd, param); +ath11k_wmi_copy_peer_flags (cmd, param, +test_bit (ATH11K_FLAG_HW_CRYPTO_DISABLED , + &ar->ab->dev_flags));ether_addr_copy (cmd->peer_macaddr.addr, param->peer_mac);
Signature · 1 line
2.7.4
Quoted 10 lines · Seevalamuthu Mariappan
Incase of hardware encryption,
WMI_PEER_AUTHflag will be set by firmware during install key. Since install key wont be done for software encryption mode, firmware will not set this flag. Due to this, seeing traffic failure in software encryption. Hence, avoid resetting peer auth flag if hardware encryption disabled.Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01421-QCAHKSWPL_SILICONZ-1
Signed-off-by Seevalamuthu Mariappan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
1daf58b23a1e ath11k: Ignore resetting peer auth flag in peer assoc cmd
Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 10 lines · Seevalamuthu Mariappan
Incase of hardware encryption,
WMI_PEER_AUTHflag will be set by firmware during install key. Since install key wont be done for software encryption mode, firmware will not set this flag. Due to this, seeing traffic failure in software encryption. Hence, avoid resetting peer auth flag if hardware encryption disabled.Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01421-QCAHKSWPL_SILICONZ-1
Signed-off-by Seevalamuthu Mariappan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
1daf58b23a1e ath11k: Ignore resetting peer auth flag in peer assoc cmd
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches