Asoc: qcom: Fix for problem in resume with CRAS
Subsystems (4)
PATCH 1/1 Asoc: qcom: Fix for problem in resume with CRAS
To support playback continuation after resume problem in chrome audio server:
Prepare device in platform trigger callback.
Make I2s and DMA control registers as non volatile.
--- sound/soc/qcom/lpass-cpu.c | 8 ++------ sound/soc/qcom/lpass-platform.c | 5 +++-- 2 files changed, 5 insertions(+), 8 deletions(-)
sound/soc/qcom/lpass-cpu.c +2 -6
@@ -454,20 +454,16 @@ static bool lpass_cpu_regmap_volatile(struct device *dev, unsigned int reg)struct lpass_variant *v = drvdata->variant;int i; -for (i =0 ; i < v->i2s_ports; ++i) -if (reg ==LPAIF_I2SCTL_REG (v, i)) -return true;for (i =0 ; i < v->irq_ports; ++i)if (reg ==LPAIF_IRQSTAT_REG (v, i))return true;for (i =0 ; i < v->rdma_channels; ++i) -if (reg ==LPAIF_RDMACURR_REG (v, i) || reg ==LPAIF_RDMACTL_REG (v, i)) +if (reg ==LPAIF_RDMACURR_REG (v, i))return true;for (i =0 ; i < v->wrdma_channels; ++i) -if (reg ==LPAIF_WRDMACURR_REG (v, i + v->wrdma_channel_start) || - reg ==LPAIF_WRDMACTL_REG (v, i + v->wrdma_channel_start)) +if (reg ==LPAIF_WRDMACURR_REG (v, i + v->wrdma_channel_start))return true;return false;
sound/soc/qcom/lpass-platform.c +3 -2
@@ -481,8 +481,9 @@ static int lpass_platform_pcmops_trigger(struct snd_soc_component *component,return -ENOTRECOVERABLE ; }switch (cmd) { -case SNDRV_PCM_TRIGGER_START :case SNDRV_PCM_TRIGGER_RESUME : +lpass_platform_pcmops_prepare (component, substream); +case SNDRV_PCM_TRIGGER_START :case SNDRV_PCM_TRIGGER_PAUSE_RELEASE : ret =regmap_fields_write (dmactl->enable, id,LPAIF_DMACTL_ENABLE_ON );
@@ -592,7 +593,7 @@ static int lpass_platform_pcmops_trigger(struct snd_soc_component *component,break ; } -return 0 ; +return ret; } static snd_pcm_uframes_t lpass_platform_pcmops_pointer(
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Mark Brown
maintainerQuoted 4 lines · Srinivasa Rao Mandadapu
To support playback continuation after resume problem in chrome audio server:
Prepare device in platform trigger callback.
Make I2s and DMA control registers as non volatile.
What is the actual issue this is fixing?
As I have previously said please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Thanks Mark for your time!!!
Quoted 6 lines · Mark Brown
Quoted 4 lines · Srinivasa Rao Mandadapu
To support playback continuation after resume problem in chrome audio server:
Prepare device in platform trigger callback.
Make I2s and DMA control registers as non volatile.What is the actual issue this is fixing?
Please ignore this patch. Posted new version of patch( [PATCH v3] ASoC: qcom: Fix playback recover problem in suspend resume) instead of this.
Quoted 7 lines
As I have previously said please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Previously I could not understand what is the mistake in subject line. Now I understood
the mistake and will take care of it next time.
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.