irqchip/loongson-htpic: Fix build warnings
Subsystems (3)
Huacai Chen
maintainerPATCH 1/1 irqchip/loongson-htpic: Fix build warnings
Fix build warnings as below:
drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
Quoted 1 line
Quoted 1 line
drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
62 | uint32_t val;
| ^~~ drivers/irqchip/irq-loongson-htpic.c: At top level:
Quoted 1 line
Quoted 1 line
drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~
--- drivers/irqchip/irq-loongson-htpic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/irqchip/irq-loongson-htpic.c +3 -4
@@ -59,11 +59,10 @@ static void htpic_reg_init(void)int i;for (i =0 ; i <HTINT_NUM_VECTORS ; i++) { -uint32_t val; -/* Disable all HT Vectors */ writel (0x0 , htpic->base +HTINT_EN_OFF + i *0x4 ); - val =readl (htpic->base + i *0x4 ); +/* Read back to force write */ + (void )readl (htpic->base + i *0x4 );/* Ack all possible pending IRQs */ writel (GENMASK (31 ,0 ), htpic->base + i *0x4 ); }
@@ -81,7 +80,7 @@ struct syscore_ops htpic_syscore_ops = { .resume = htpic_resume, }; -int __init htpic_of_init (struct device_node *node,struct device_node *parent) +static int __init htpic_of_init (struct device_node *node,struct device_node *parent) {unsigned int parent_irq[4 ];int i, err;
Signature · 1 line
2.7.0
Marc Zyngier
AppliedQuoted 10 lines · Huacai Chen
Fix build warnings as below:
drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':Quoted 1 line
Quoted 1 line
drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]62 | uint32_t val; | ^~~
drivers/irqchip/irq-loongson-htpic.c: At top level:Quoted 1 line
Quoted 1 line
drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]84 | int
__inithtpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/loongson-htpic: Fix build warnings
commit: 3ee36352e26935c7e8145eb4e7ed38b536ca01fc
Cheers,
M.
Signature · 8 lines
Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 3ee36352e26935c7e8145eb4e7ed38b536ca01fc Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3ee36352e26935c7e8145eb4e7ed38b536ca01fc Author: Huacai Chen <[email protected]> AuthorDate: Sat, 05 Dec 2020 17:15:44 +08:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Fri, 11 Dec 2020 14:40:17
irqchip/loongson-htpic: Fix build warnings
Fix build warnings as below:
drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
Quoted 1 line
Quoted 1 line
drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
62 | uint32_t val;
| ^~~ drivers/irqchip/irq-loongson-htpic.c: At top level:
Quoted 1 line
Quoted 1 line
drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~
--- drivers/irqchip/irq-loongson-htpic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/irqchip/irq-loongson-htpic.c +3 -4
@@ -59,11 +59,10 @@ static void htpic_reg_init(void)int i;for (i =0 ; i <HTINT_NUM_VECTORS ; i++) { -uint32_t val; -/* Disable all HT Vectors */ writel (0x0 , htpic->base +HTINT_EN_OFF + i *0x4 ); - val =readl (htpic->base + i *0x4 ); +/* Read back to force write */ + (void )readl (htpic->base + i *0x4 );/* Ack all possible pending IRQs */ writel (GENMASK (31 ,0 ), htpic->base + i *0x4 ); }
@@ -81,7 +80,7 @@ struct syscore_ops htpic_syscore_ops = { .resume = htpic_resume, }; -int __init htpic_of_init (struct device_node *node,struct device_node *parent) +static int __init htpic_of_init (struct device_node *node,struct device_node *parent) {unsigned int parent_irq[4 ];int i, err;