Skip to contentSkip to conversation

mt76: Fixed kernel test robot warning

PATCH In review Souptick Joarder 2 participants 5 messages Dec 9, 2020 – Dec 11, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mt76: Fixed kernel test robot warning

Kernel test robot throws below warning ->

drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':

Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' set but not used [-Wunused-but-set-variable]

     499 |  struct mt76_queue *q;
         |                     ^

This patch will silence this warning.

---
 drivers/net/wireless/mediatek/mt76/tx.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/wireless/mediatek/mt76/tx.c +0 -3
index 1e20afb..25627e7 100644
@@ -504,14 +504,11 @@ void mt76_tx_complete_skb(struct mt76_dev *dev, u16 wcid_idx, struct sk_buff *sk
 
 void mt76_txq_schedule(struct mt76_phy *phy, enum mt76_txq_id qid)
 {
-	struct mt76_queue *q;
 	int len;
 
 	if (qid >= 4)
 		return;
 
-	q = phy->q_tx[qid];
-
 	rcu_read_lock();
 
 	do {
Signature · 7 lines
1.9.1


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#1 lore raw
Quoted 6 lines · Souptick Joarder

Kernel test robot throws below warning ->

drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':

Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' set but not used [-Wunused-but-set-variable]

Quoted 7 lines
     499 |  struct mt76_queue *q;
         |                     ^

This patch will silence this warning.

I would like to take this directly to wireless-drivers-next, ok?

I'll also change the title to:

mt76: remove unused variable q

Signature · 8 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#2 lore raw
Quoted 12 lines · Kalle Valo
Quoted 9 lines · Souptick Joarder

Kernel test robot throws below warning ->

drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':

Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' set but not used [-Wunused-but-set-variable]

     499 |  struct mt76_queue *q;
         |                     ^
Quoted 6 lines
Quoted 4 lines

This patch will silence this warning.

I would like to take this directly to wireless-drivers-next, ok?

Ok.

Quoted 9 lines

I'll also change the title to:

mt76: remove unused variable q

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

#3 lore raw

Re: mt76: remove unused variable q

In reply to Souptick Joarder
Quoted 11 lines · Souptick Joarder

Kernel test robot reported warning:

drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':

Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' set but not used [-Wunused-but-set-variable]

     499 |  struct mt76_queue *q;
         |                     ^

Patch applied to wireless-drivers-next.git, thanks.

7f469b6dc484 mt76: remove unused variable q

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#4 lore raw

Re: mt76: remove unused variable q

In reply to Souptick Joarder
Quoted 11 lines · Souptick Joarder

Kernel test robot reported warning:

drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':

Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' set but not used [-Wunused-but-set-variable]

     499 |  struct mt76_queue *q;
         |                     ^

Patch applied to wireless-drivers-next.git, thanks.

7f469b6dc484 mt76: remove unused variable q

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches