scsi: ufs: Fix a possible NULL pointer issue
PATCH 1/1 scsi: ufs: Fix a possible NULL pointer issue
During system resume/suspend, hba could be NULL. In this case, do not touch eh_sem.
Fixes 88a92d6ae4fe ("scsi: ufs: Serialize eh_work with system PM events and async scan")
Signed-off-by Can Guo <[email protected]>
--- drivers/scsi/ufs/ufshcd.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/scsi/ufs/ufshcd.c +7 -5
@@ -8883,9 +8883,13 @@ int ufshcd_system_suspend(struct ufs_hba *hba)int ret =0 ;ktime_t start =ktime_get (); -down (&hba->eh_sem); -if (!hba || !hba->is_powered) +if (!hba) +return 0 ; + +if (!hba->is_powered) { +down (&hba->eh_sem);return 0 ; + } if ((ufs_get_pm_lvl_to_dev_pwr_mode(hba->spm_lvl) == hba->curr_dev_pwr_mode) &&
@@ -8932,10 +8936,8 @@ int ufshcd_system_resume(struct ufs_hba *hba)int ret =0 ;ktime_t start =ktime_get (); -if (!hba) { -up (&hba->eh_sem); +if (!hba)return -EINVAL ; - }if (!hba->is_powered ||pm_runtime_suspended (hba->dev))/*
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.