Skip to contentSkip to conversation

perf/core: Mark perf_pmu_snapshot_aux() as static

PATCH In review Souptick Joarder 1 participant 2 messages Jan 9, 2021 – Apr 2, 2021 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf/core: Mark perf_pmu_snapshot_aux() as static

Kernel test robot throws below warning ->

kernel/events/core.c:6535:6: warning: no previous prototype for
'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
| ^~~~~~~~~~~~~~~~~~~~~
Marking perf_pmu_snapshot_aux() as static as it is not used outside this file.

---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +1 -1
index 55d1879..a4ba6fd 100644
@@ -6532,7 +6532,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
 	return data->aux_size;
 }
 
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
 			   struct perf_event *event,
 			   struct perf_output_handle *handle,
 			   unsigned long size)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 10 lines · Souptick Joarder

Kernel test robot throws below warning ->

kernel/events/core.c:6535:6: warning: no previous prototype for
'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
| ^~~~~~~~~~~~~~~~~~~~~
Marking perf_pmu_snapshot_aux() as static as it is not used outside this file.

Quoted 2 lines

Any comment on this patch ?

Quoted 20 lines
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +1 -2
index 55d1879..a4ba6fd 100644
@@ -6532,7 +6532,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
        return data->aux_size;
 }
 
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
                           struct perf_event *event,
                           struct perf_output_handle *handle,
                           unsigned long size)
--

1.9.1