lib/cmdline: add new function get_option_ull()
PATCH 1/2 lib/cmdline: add new function get_option_ull()
From: "Wesley.Zhao" <[email protected]>
In the future we would pass the unsigned long long parameter like(0x123456781234) in cmdline on the 64bit platform, so add a new option parse function get_option_ull()
--- include/linux/kernel.h | 1 + lib/cmdline.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+)
include/linux/kernel.h +1 -0
@@ -348,6 +348,7 @@ extern __scanf(2, 0)int vsscanf (const char *,const char *,va_list );extern int get_option (char **str,int *pint); +extern int get_option_ull (char **str,unsigned long long *pull);extern char *get_options (const char *str,int nints,int *ints);extern unsigned long long memparse (const char *ptr,char **retptr);extern bool parse_option_str (const char *str,const char *option);
lib/cmdline.c +35 -0
@@ -80,6 +80,41 @@ int get_option(char **str, int *pint)EXPORT_SYMBOL (get_option);/** +* get_option_ull - Parse unsigned long long from an option string +* @str: option string +* @pull: (output) unsigned long long value parsed from @str +* +* Read an unsigned long long from an option string; if available accept a subsequent +* comma as well. +* +* Return values: +* 0 - no ull in string +* 1 - ull found, no subsequent comma +* 2 - ull found including a subsequent comma +* 3 - hyphen found to denote a range +*/ + +int get_option_ull (char **str,unsigned long long *pull) +{ +char *cur = *str; + +if (!cur || !(*cur)) +return 0 ; + *pull =simple_strtoull (cur, str,0 ); +if (cur == *str) +return 0 ; +if (**str ==',' ) { + (*str)++; +return 2 ; + } +if (**str =='-' ) +return 3 ; + +return 1 ; +} +EXPORT_SYMBOL (get_option_ull); + +/** * get_options - Parse a string into a list of integers * @str: String to be parsed * @nints: size of integer array
Signature · 1 line
2.7.4
PATCH 2/2 resource: Make it possible to reserve memory on 64bit platform
From: "Wesley.Zhao" <[email protected]>
For now "reserve=" is limitied to 32bit,not available on 64bit platform,so we change the get_option() to get_option_ull(added in
patch: commit 4b6bfe96265e ("lib/cmdline: add new function get_option_ull()"))
--- kernel/resource.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/resource.c +3 -3
@@ -1567,13 +1567,13 @@ static int __init reserve_setup(char *str)static struct resource reserve[MAXRESERVE ];for (;;) { -unsigned int io_start, io_num; +unsigned long long io_start, io_num;int x = reserved;struct resource *parent; -if (get_option (&str, &io_start) !=2 ) +if (get_option_ull (&str, &io_start) !=2 )break ; -if (get_option (&str, &io_num) ==0 ) +if (get_option_ull (&str, &io_num) ==0 )break ;if (x <MAXRESERVE ) {struct resource *res = reserve + x;
Signature · 1 line
2.7.4
Re: [PATCH 2/2] resource: Make it possible to reserve memory on 64bit platform
Quoted 6 lines · Wesley Zhao
From: "Wesley.Zhao" <[email protected]>
For now "reserve=" is limitied to 32bit,not available on 64bit platform,so we change the
get_option()to get_option_ull(added in
patch: commit4b6bfe96265e("lib/cmdline: add new functionget_option_ull()"))
Curious, what's the target use case? (did not receive a cover letter, maybe it's buried in there)
Signature · 3 lines
Thanks, David / dhildenb
Re: [PATCH 2/2] resource: Make it possible to reserve memory on 64bit platform
Quoted 10 lines · David Hildenbrand
Quoted 6 lines · Wesley Zhao
From: "Wesley.Zhao" <[email protected]>
For now "reserve=" is limitied to 32bit,not available on 64bit platform,so we change the
get_option()to get_option_ull(added in
patch: commit4b6bfe96265e("lib/cmdline: add new functionget_option_ull()"))Curious, what's the target use case? (did not receive a cover letter, maybe it's buried in there)
Oh, I didn't received neither cover letter nor patch 2!
To author: please, address comments to patch 1 along with (re)sending cover letter and include every stakeholder to the entire series.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 5 lines · Wesley Zhao
From: "Wesley.Zhao" <[email protected]>
In the future we would pass the unsigned long long parameter like(0x123456781234) in cmdline on the 64bit platform, so add a new option parse function
get_option_ull()
No negative numbers?
No test cases?
No user?
Please, address above.
Besides that, consider to deduplicate (like it's done in simple_strto*() family of functions), so we don't have two implementation that are basically do the same, only put result to a different type of variable.
Signature · 2 lines
With Best Regards, Andy Shevchenko