build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
PATCH 1/1 build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
From: Tyler Retzlaff <[email protected]>
--- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+)
lib/librte_eal/common/meson.build +1 -0
@@ -34,6 +34,7 @@ if is_windows 'rte_malloc.c', 'eal_common_timer.c', 'rte_service.c', + 'rte_reciprocal.c', ) subdir_done() endif
lib/librte_eal/rte_eal_exports.def +1 -0
@@ -326,3 +326,4 @@ EXPORTS rte_mem_map rte_mem_page_size rte_mem_unmap + rte_reciprocal_value_u64
Signature · 1 line
2.29.0.vfs.0.0
On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
<[email protected]> wrote:
Commitlog please.
Quoted 25 lines
From: Tyler Retzlaff <[email protected]>
--- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+)lib/librte_eal/common/meson.build +1
-0@@ -34,6 +34,7 @@ if is_windows 'rte_malloc.c', 'eal_common_timer.c', 'rte_service.c', + 'rte_reciprocal.c', ) subdir_done() endiflib/librte_eal/rte_eal_exports.def +0
-0
lib/librte_eal/rte_eal_exports.def EXPORTS · line 329
Quoted 4 lines
lib/librte_eal/rte_eal_exports.def +1
-0@@ -326,3 +326,4 @@ EXPORTS rte_mem_map rte_mem_page_size rte_mem_unmap + rte_reciprocal_value_u64
Looking at rte_reciprocal.c/.h and EAL version.map, this API exports two symbols.
If there is no reason why the other symbol has been skipped, please add both:
rte_reciprocal_value
rte_reciprocal_value_u64
Signature · 1 line
David Marchand
Quoted 33 lines · David Marchand
On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
<[email protected]> wrote:Commitlog please.
Quoted 27 lines
From: Tyler Retzlaff <[email protected]>
--- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+)lib/librte_eal/common/meson.build +1
-0@@ -34,6 +34,7 @@ if is_windows 'rte_malloc.c', 'eal_common_timer.c', 'rte_service.c', + 'rte_reciprocal.c', ) subdir_done() endiflib/librte_eal/rte_eal_exports.def +0
-0@@ -326,3 +326,4 @@ EXPORTS rte_mem_map rte_mem_page_size
Quoted 8 lines
lib/librte_eal/rte_eal_exports.def EXPORTS · line 329
Quoted 2 lines
lib/librte_eal/rte_eal_exports.def +1
-0rte_mem_unmap + rte_reciprocal_value_u64Looking at rte_reciprocal.c/.h and EAL version.map, this API exports two symbols.
If there is no reason why the other symbol has been skipped, please add both:
rte_reciprocal_value
rte_reciprocal_value_u64
Dmitry made the same comments on another (unthreaded) version of this patch, so we are good.
Signature · 1 line
David Marchand
hi,
Quoted 3 lines · David Marchand
Dmitry made the same comments on another (unthreaded) version of this patch, so we are good.
apologies for this, I fat fingered the submission of v2 of the patch and split the thread unintentionally.
readers should regard this thread as dead.
Quoted 3 lines
Signature · 2 lines
-- David Marchand