net/bridge: Fix inconsistent format argument types
Subsystems (3)
PATCH 1/1 net/bridge: Fix inconsistent format argument types
Fix the following warnings:
net/bridge/br_sysfs_br.c(833): warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. net/bridge/br_sysfs_br.c(817): warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. net/bridge/br_sysfs_br.c(261): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_br.c(253): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_br.c(244): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_br.c(236): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'.
--- net/bridge/br_sysfs_br.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
net/bridge/br_sysfs_br.c +6 -6
@@ -233,7 +233,7 @@ static ssize_t hello_timer_show(struct device *d, struct device_attribute *attr, char *buf) { struct net_bridge *br = to_bridge(d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->hello_timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->hello_timer)); }static DEVICE_ATTR_RO (hello_timer);
@@ -241,7 +241,7 @@ static ssize_t tcn_timer_show(struct device *d, struct device_attribute *attr, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->tcn_timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->tcn_timer)); }static DEVICE_ATTR_RO (tcn_timer);
@@ -250,7 +250,7 @@ static ssize_t topology_change_timer_show(struct device *d, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->topology_change_timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->topology_change_timer)); }static DEVICE_ATTR_RO (topology_change_timer);
@@ -258,7 +258,7 @@ static ssize_t gc_timer_show(struct device *d, struct device_attribute *attr, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->gc_work.timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->gc_work.timer)); }static DEVICE_ATTR_RO (gc_timer);
@@ -814,7 +814,7 @@ static ssize_t vlan_stats_enabled_show(struct device *d, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%u\n" ,br_opt_get (br,BROPT_VLAN_STATS_ENABLED )); +return sprintf (buf,"%d\n" ,br_opt_get (br,BROPT_VLAN_STATS_ENABLED )); } static ssize_t vlan_stats_enabled_store(struct device *d,
@@ -830,7 +830,7 @@ static ssize_t vlan_stats_per_port_show(struct device *d, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%u\n" ,br_opt_get (br,BROPT_VLAN_STATS_PER_PORT )); +return sprintf (buf,"%d\n" ,br_opt_get (br,BROPT_VLAN_STATS_PER_PORT )); } static ssize_t vlan_stats_per_port_store(struct device *d,
Signature · 1 line
1.8.3.1
Quoted 15 lines · Jiapeng Zhong
Fix the following warnings:
net/bridge/br_sysfs_br.c(833): warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. net/bridge/br_sysfs_br.c(817): warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. net/bridge/br_sysfs_br.c(261): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_br.c(253): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_br.c(244): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_br.c(236): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'.
Quoted 6 lines
Signed-off-by Jiapeng Zhong <[email protected]>Reported-by Abaci Robot<[email protected]>--- net/bridge/br_sysfs_br.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Hi,
You have sent 2 patches with the same subject.. Please squash them into a single patch and target it to net-next, these don't need to be backported.
Thanks,
Nik
Quoted 59 lines
net/bridge/br_sysfs_br.c +6
-6@@ -233,7 +233,7 @@ static ssize_t hello_timer_show(struct device *d, struct device_attribute *attr, char *buf) { struct net_bridge *br = to_bridge(d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->hello_timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->hello_timer)); }static DEVICE_ATTR_RO (hello_timer);@@ -241,7 +241,7 @@ static ssize_t tcn_timer_show(struct device *d, struct device_attribute *attr, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->tcn_timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->tcn_timer)); }static DEVICE_ATTR_RO (tcn_timer);@@ -250,7 +250,7 @@ static ssize_t topology_change_timer_show(struct device *d, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->topology_change_timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->topology_change_timer)); }static DEVICE_ATTR_RO (topology_change_timer);@@ -258,7 +258,7 @@ static ssize_t gc_timer_show(struct device *d, struct device_attribute *attr, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%ld\n" ,br_timer_value (&br->gc_work.timer)); +return sprintf (buf,"%lu\n" ,br_timer_value (&br->gc_work.timer)); }static DEVICE_ATTR_RO (gc_timer);@@ -814,7 +814,7 @@ static ssize_t vlan_stats_enabled_show(struct device *d, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%u\n" ,br_opt_get (br,BROPT_VLAN_STATS_ENABLED )); +return sprintf (buf,"%d\n" ,br_opt_get (br,BROPT_VLAN_STATS_ENABLED )); } static ssize_t vlan_stats_enabled_store(struct device *d,@@ -830,7 +830,7 @@ static ssize_t vlan_stats_per_port_show(struct device *d, char *buf) {struct net_bridge *br =to_bridge (d); -return sprintf (buf,"%u\n" ,br_opt_get (br,BROPT_VLAN_STATS_PER_PORT )); +return sprintf (buf,"%d\n" ,br_opt_get (br,BROPT_VLAN_STATS_PER_PORT )); } static ssize_t vlan_stats_per_port_store(struct device *d,