usb typec: tcpci: mt6360: Add vsafe0v support and external vbus supply control
Subsystems (5)
PATCH 1/2 usb typec: tcpci: mt6360: Add vsafe0v support and external vbus supply control
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink. Uses external 5V vbus regulator as the vbus source control.
Also adds the capability to report vsafe0v.
--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
drivers/usb/typec/tcpm/tcpci_mt6360.c +29 -0
@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h"
@@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };
@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); } +static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk) +{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + } + +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;
@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq; + mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH 2/2 usb typec: tcpci: mt6360: Add vbus supply into dt-binding description
From: ChiYuan Huang <[email protected]>
Add external vbus source into dt-binding description.
--- Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +7 -0
@@ -26,6 +26,11 @@ properties: items: - const: PD_IRQB + vbus-supply: + description: + Vbus source supply regulator. + maxItems: 1 + connector: type: object $ref: ../connector/usb-connector.yaml#
@@ -38,6 +43,7 @@ required: - compatible - interrupts - interrupt-names + - vbus-supply examples: - |
@@ -54,6 +60,7 @@ examples: compatible = "mediatek,mt6360-tcpc"; interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; interrupt-names = "PD_IRQB"; + vbus-supply = <&otg_vbus>; connector { compatible = "usb-c-connector";
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Rob Herring
maintainerRe: [PATCH 2/2] usb typec: tcpci: mt6360: Add vbus supply into dt-binding description
Quoted 9 lines · cy_huang
From: ChiYuan Huang <[email protected]>
Add external vbus source into dt-binding description.
Signed-off-by ChiYuan Huang <[email protected]>--- Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml: properties:vbus-supply: 'maxItems' is not one of ['description', 'deprecated'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml: ignoring, error in schema: properties: vbus-supply
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
See https://patchwork.ozlabs.org/patch/1427073
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 3 lines · cy_huang
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Use
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail. I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Thanks,
Guenter
Quoted 30 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +3
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); } +static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk)
drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 10 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }
Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Quoted 18 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq;
drivers/usb/typec/tcpm/tcpci_mt6360.c static int mt6360_tcpc_probe(struct platform_device *pdev) · line 173
Quoted 10 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +6
-0+ mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Guenter Roeck <[email protected]> 於 2021年1月18日 週一 上午1:43寫道:
Quoted 8 lines · cy_huang
Quoted 3 lines
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Ack
Quoted 4 lines
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Use
Ack
Quoted 4 lines
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
Ack
Quoted 5 lines
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail. I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Yes, I already checked all the src/snk functionality based on the latest typec code.
It'll be common for our TCPC. It didn't support for TCPC command. From the recent patches, actually, I have the local change to test the src capability.
But I didn't submit it. It's almost the same to add set_vbus callback. That's why I submit this change after tcpci 'set_vbus callback' is added.
Quoted 32 lines
Thanks,
GuenterQuoted 29 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +2
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); }
Quoted 15 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +11
-0+static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk) +{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Yes, for the state change from src_attach_wait to src_attach, It need to meet the requirement that the vbus is at vsafe0v. So to disable it first is needed.
And to prevent other users from enabling/disabling external vbus regulator in any case.
I think we may change regulator_get to 'regulator_get_exclusive'. From the design, 5v regulator only can be controlled via typec framework. If other user touch it, it'll affect the typec state transition.
Quoted 17 lines
Quoted 17 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq;
Quoted 12 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static int mt6360_tcpc_probe(struct platform_device *pdev) · line 173
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +6
-0+ mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH 2/2] usb typec: tcpci: mt6360: Add vbus supply into dt-binding description
In reply to Rob HerringRob Herring <[email protected]> 於 2021年1月17日 週日 下午11:46寫道:
Quoted 26 lines · cy_huang
Quoted 9 lines
From: ChiYuan Huang <[email protected]>
Add external vbus source into dt-binding description.
Signed-off-by ChiYuan Huang <[email protected]>--- Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)My bot found errors running 'make
dt_binding_check' on your patch:yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml: properties:vbus-supply: 'maxItems' is not one of ['description', 'deprecated'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml: ignoring, error in schema: properties: vbus-supply
warning: no schema found in file:./Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yamlSee https://patchwork.ozlabs.org/patch/1427073
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
Quoted 8 lines
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:pip3 install dtschema --upgrade
Please check and re-submit.
Thanks, after I re-installed the yamlint, the error can be seen.
Refer to https://www.kernel.org/doc/Documentation/devicetree/bindings/example-schema.yaml
*-supply is only a phandle
In next series patch, I'll remove the maxItems in vbus-supply. I already checked the below change. make dt_binding_check can be passed
vbus-supply:
description:
Vbus source supply regulator.
- maxItems: 1
connector:
type: object
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Chunfeng Yun
maintainerQuoted 9 lines · Guenter Roeck
Quoted 3 lines · cy_huang
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Quoted 8 lines
Use
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail.
If don't provide vbus-supply in DTS, regulator framework will provide a dummy regulator, so the code will not fail.
Quoted 80 lines
I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Thanks,
GuenterQuoted 30 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +3
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); } +static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk)drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 10 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Quoted 28 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +16
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq; + mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
Chunfeng Yun
maintainerQuoted 80 lines · ChiYuan Huang
Guenter Roeck <[email protected]> 於 2021年1月18日 週一 上午1:43寫道:
Quoted 8 lines · cy_huang
Quoted 3 lines
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Ack
Quoted 4 lines
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Use
Ack
Quoted 4 lines
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
Ack
Quoted 5 lines
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail. I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Yes, I already checked all the src/snk functionality based on the latest typec code.
It'll be common for our TCPC. It didn't support for TCPC command. From the recent patches, actually, I have the local change to test the src capability.
But I didn't submit it. It's almost the same to addset_vbuscallback. That's why I submit this change after tcpci 'set_vbuscallback' is added.Quoted 32 lines
Thanks,
GuenterQuoted 29 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +2
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); }Quoted 15 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +11
-0+static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk) +{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Quoted 8 lines
Yes, for the state change from
src_attach_waittosrc_attach, It need to meet the requirement that the vbus is at vsafe0v. So to disable it first is needed.
And to prevent other users from enabling/disabling external vbus regulator in any case.
I think we may changeregulator_getto 'regulator_get_exclusive'. From the design, 5v regulator only can be controlled via typec framework. If other user touch it, it'll affect the typec state transition.
How about to process the case that even switch usb controller to device mode, platform also need to keep vbus on? e.g. Iphone Carplay
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq;
Quoted 12 lines
Quoted 12 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static int mt6360_tcpc_probe(struct platform_device *pdev) · line 173
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +6
-0+ mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Chunfeng Yun <[email protected]> 於 2021年1月19日 週二 下午3:33寫道:
Quoted 13 lines · Guenter Roeck
Quoted 11 lines · cy_huang
Quoted 3 lines
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Use
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail.
If don't provide vbus-supply in DTS, regulator framework will provide a dummy regulator, so the code will not fail.
In the last reply, I will change from regulator_get toregulator_get_exclusive, it will return -ENODEV.
The IS_ERR can catch this situation, no dummy regulator will be returned.
And assume no vbus 5v for source & snk attached, It will cause typec state machine repeated from
drp -> src_attach_wait -> src_attached -> PD_T_PS_SOURCE_on timeout. It will be stuck in the loop until snk detached.
Quoted 68 lines
Quoted 68 lines
I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Thanks,
GuenterQuoted 30 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +3
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); } +static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk)drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 10 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Quoted 17 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq;
Quoted 13 lines
Quoted 12 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static int mt6360_tcpc_probe(struct platform_device *pdev) · line 173
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +6
-0+ mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Chunfeng Yun <[email protected]> 於 2021年1月19日 週二 下午3:38寫道:
Quoted 90 lines · ChiYuan Huang
Quoted 80 lines
Guenter Roeck <[email protected]> 於 2021年1月18日 週一 上午1:43寫道:
Quoted 8 lines · cy_huang
Quoted 3 lines
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Ack
Quoted 4 lines
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Use
Ack
Quoted 4 lines
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
Ack
Quoted 5 lines
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail. I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Yes, I already checked all the src/snk functionality based on the latest typec code.
It'll be common for our TCPC. It didn't support for TCPC command. From the recent patches, actually, I have the local change to test the src capability.
But I didn't submit it. It's almost the same to addset_vbuscallback. That's why I submit this change after tcpci 'set_vbuscallback' is added.Quoted 32 lines
Thanks,
GuenterQuoted 29 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +2
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); }Quoted 15 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +11
-0+static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk) +{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Quoted 8 lines
Yes, for the state change from
src_attach_waittosrc_attach, It need to meet the requirement that the vbus is at vsafe0v. So to disable it first is needed.
And to prevent other users from enabling/disabling external vbus regulator in any case.
I think we may changeregulator_getto 'regulator_get_exclusive'. From the design, 5v regulator only can be controlled via typec framework. If other user touch it, it'll affect the typec state transition.
Quoted 4 lines
How about to process the case that even switch usb controller to device mode, platform also need to keep vbus on? e.g. Iphone Carplay
It must be processed by USBPD data role swap.
Type C only decide the initial role (SNK: power snk and ufp; SRC:
power src and DFP).
Only USBPD can change the power/data/vconn role individually.
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +10
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq;
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +4
-0+ mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); +Quoted 8 lines
Quoted 8 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static int mt6360_tcpc_probe(struct platform_device *pdev) · line 173
Quoted 7 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +2
-0mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Rob Herring
maintainerRe: [PATCH 2/2] usb typec: tcpci: mt6360: Add vbus supply into dt-binding description
In reply to cy_huangQuoted 14 lines · cy_huang
From: ChiYuan Huang <[email protected]>
Add external vbus source into dt-binding description.
Signed-off-by ChiYuan Huang <[email protected]>--- Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +0
-0
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml properties: · line 32
Quoted 7 lines
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +4
-0@@ -26,6 +26,11 @@ properties: items: - const: PD_IRQB + vbus-supply: + description: + Vbus source supply regulator. + maxItems: 1
vbus-supply is already in the 'connector' node, you don't need it here.
Quoted 23 lines
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +3
-0+ connector: type: object $ref: ../connector/usb-connector.yaml#@@ -38,6 +43,7 @@ required: - compatible - interrupts - interrupt-names + - vbus-supply examples: - |@@ -54,6 +60,7 @@ examples: compatible = "mediatek,mt6360-tcpc"; interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; interrupt-names = "PD_IRQB"; + vbus-supply = <&otg_vbus>; connector { compatible = "usb-c-connector";Signature · 1 line
2.7.4
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH 2/2] usb typec: tcpci: mt6360: Add vbus supply into dt-binding description
Rob Herring <[email protected]> 於 2021年1月20日 週三 上午7:11寫道:
Quoted 19 lines · cy_huang
Quoted 17 lines
From: ChiYuan Huang <[email protected]>
Add external vbus source into dt-binding description.
Signed-off-by ChiYuan Huang <[email protected]>--- Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +0
-0@@ -26,6 +26,11 @@ properties: items: - const: PD_IRQB
Quoted 7 lines
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml properties: · line 32
Quoted 4 lines
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +4
-0+ vbus-supply: + description: + Vbus source supply regulator. + maxItems: 1vbus-supply is already in the 'connector' node, you don't need it here.
If not put here, 'regulator_get' only can follow the legacy way to get vbus regulator.
Currently, there's no one to use the 'vbus-supply' property. From my understanding, the 'vbus-supply' is the chip level property, not connector type property.
Quoted 18 lines
Quoted 18 lines
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +3
-0+ connector: type: object $ref: ../connector/usb-connector.yaml#@@ -38,6 +43,7 @@ required: - compatible - interrupts - interrupt-names + - vbus-supply examples: - |@@ -54,6 +60,7 @@ examples: compatible = "mediatek,mt6360-tcpc"; interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; interrupt-names = "PD_IRQB"; + vbus-supply = <&otg_vbus>;
Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +0
-1connector { compatible = "usb-c-connector"; --2.7.4
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
HI, reviews:
ChiYuan Huang <[email protected]> 於 2021年1月19日 週二 下午4:23寫道:
Quoted 96 lines
Chunfeng Yun <[email protected]> 於 2021年1月19日 週二 下午3:38寫道:
Quoted 90 lines · ChiYuan Huang
Quoted 80 lines
Guenter Roeck <[email protected]> 於 2021年1月18日 週一 上午1:43寫道:
Quoted 8 lines · cy_huang
Quoted 3 lines
From: ChiYuan Huang <[email protected]>
MT6360 not support for TCPC command to control source and sink.
does not
Ack
Quoted 4 lines
Quoted 2 lines
Uses external 5V vbus regulator as the vbus source control.
Use
Ack
Quoted 4 lines
Quoted 2 lines
Also adds the capability to report vsafe0v.
add
Ack
Quoted 5 lines
So far this driver works without regulator. Unless I am missing something, this patch makes regulator support mandatory, meaning existing code will fail. I am not sure if that is appropriate/acceptable. Can we be sure that this will work for existing users of this driver ?
Yes, I already checked all the src/snk functionality based on the latest typec code.
It'll be common for our TCPC. It didn't support for TCPC command. From the recent patches, actually, I have the local change to test the src capability.
But I didn't submit it. It's almost the same to addset_vbuscallback. That's why I submit this change after tcpci 'set_vbuscallback' is added.Quoted 32 lines
Thanks,
GuenterQuoted 29 lines
Signed-off-by ChiYuan Huang <[email protected]>--- drivers/usb/typec/tcpm/tcpci_mt6360.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)drivers/usb/typec/tcpm/tcpci_mt6360.c +2
-0@@ -11,6 +11,7 @@#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/usb/tcpm.h> #include "tcpci.h" @@ -36,6 +37,7 @@ struct mt6360_tcpc_info {struct tcpci_data tdata;struct tcpci *tcpci;struct device *dev; +struct regulator *vbus;int irq; };@@ -51,6 +53,27 @@ static inline int mt6360_tcpc_write16(struct regmap *regmap,return regmap_raw_write (regmap, reg, &val,sizeof (u16)); }Quoted 15 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c static inline int mt6360_tcpc_write16(struct regmap *regmap, · line 66
Quoted 11 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +11
-0+static int mt6360_tcpc_set_vbus (struct tcpci *tcpci,struct tcpci_data *data,bool src,bool snk) +{ + struct mt6360_tcpc_info *mti = container_of(data, struct mt6360_tcpc_info, tdata); +int ret; + +/* To correctly handle the already enabled vbus and disable its supply first */ +if (regulator_is_enabled (mti->vbus)) { + ret =regulator_disable (mti->vbus); +if (ret) +return ret; + }Is it really a good idea to disable vbus if it happens to be already enabled and there is (another ?) request to enable it ?
Quoted 8 lines
Yes, for the state change from
src_attach_waittosrc_attach, It need to meet the requirement that the vbus is at vsafe0v. So to disable it first is needed.
And to prevent other users from enabling/disabling external vbus regulator in any case.
I think we may changeregulator_getto 'regulator_get_exclusive'. From the design, 5v regulator only can be controlled via typec framework. If other user touch it, it'll affect the typec state transition.Quoted 4 lines
How about to process the case that even switch usb controller to device mode, platform also need to keep vbus on? e.g. Iphone Carplay
Quoted 6 lines
It must be processed by USBPD data role swap.
Type C only decide the initial role (SNK: power snk and ufp; SRC:
power src and DFP).
Only USBPD can change the power/data/vconn role individually.
I'm not sure the status about this patch.
But I'm trying to figure out the problems about some TCPCs.
Not all TCPCs can support the source_vbus/sink_vbus command. I'm trying to add this patch make our mt6360 tcpc work.
Originally, I add some proprietary code in usb to make the otg vbus output due to no set_vbus callback handled by vendor ops.
Eventually, I found the patchb9358a068490 usb: typec: tcpci: Add set_vbus tcpci callback
Hope to get any response from you.
Quoted 30 lines
Quoted 30 lines
Quoted 29 lines
Quoted 29 lines
Quoted 28 lines
drivers/usb/typec/tcpm/tcpci_mt6360.c +16
-0+ +if (src) { + ret =regulator_enable (mti->vbus); +if (ret) +return ret; + } + +return 0 ; +} +static int mt6360_tcpc_init (struct tcpci *tcpci,struct tcpci_data *tdata) {struct regmap *regmap = tdata->regmap;@@ -138,7 +161,13 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)if (mti->irq <0 )return mti->irq; + mti->vbus =devm_regulator_get (&pdev->dev,"vbus" ); +if (IS_ERR (mti->vbus)) +return PTR_ERR (mti->vbus); + mti->tdata.init = mt6360_tcpc_init; + mti->tdata.set_vbus = mt6360_tcpc_set_vbus; + mti->tdata.vbus_vsafe0v =1 ; mti->tcpci =tcpci_register_port (&pdev->dev, &mti->tdata);if (IS_ERR (mti->tcpci)) {dev_err (&pdev->dev,"Failed to register tcpci port\n" );