In the current implementation, should_check_rate() returns false if ddir_rw_sum(td->bytes_done)==0. Therefore, a thread may violate the rate if iodepth*bs > rate.
PATCH 1/1 In the current implementation, should_check_rate() returns false if ddir_rw_sum(td->bytes_done)==0. Therefore, a thread may violate the rate if iodepth*bs > rate.
This patch addresses the issue by not checking td->bytes_done in should_check_rate.
An example of the issue:
[root@localhost test]# cat fio_randwrite
[global]
thread
kb_base=1000
direct=1
size=28GiBgroup_reporting
io_size=16384
ioengine=libaio
iodepth=2
bs=4096
iodepth_batch_submit=1
iodepth_batch_complete=1
filename=/dev/qblkdev
[fio_randwrite]
rw=randwrite
rate_iops=,1
iodepth_batch_submit=1
thinktime_blocks=1
rate_cycle=1000
thinktime=3s
rate_ignore_thinktime=1
[root@localhost test]# fio fio_randwrite
blktrace output:
259,1 11 1 0.100550729 6135 Q WS 3541608 + 8 [fio] 259,1 11 2 0.100552183 6135 G WS 3541608 + 8 [fio] 259,1 11 3 0.100560373 6135 D WS 3541608 + 8 [fio] 259,1 11 4 0.100570436 6135 C WS 3541608 + 8 [0] 259,1 11 5 0.100599816 6135 Q WS 43470024 + 8 [fio] 259,1 11 6 0.100600513 6135 G WS 43470024 + 8 [fio] 259,1 11 7 0.100601579 6135 D WS 43470024 + 8 [fio] 259,1 11 8 0.100612750 6135 C WS 43470024 + 8 [0] 259,1 11 9 3.101034407 6135 Q WS 49511928 + 8 [fio] 259,1 11 10 3.101036067 6135 G WS 49511928 + 8 [fio] 259,1 11 11 3.101054487 6135 D WS 49511928 + 8 [fio] 259,1 11 12 3.101068699 6135 C WS 49511928 + 8 [0] 259,1 11 13 6.101267480 6135 Q WS 27599368 + 8 [fio] 259,1 11 14 6.101269216 6135 G WS 27599368 + 8 [fio] 259,1 11 15 6.101277050 6135 D WS 27599368 + 8 [fio] 259,1 11 16 6.101287956 6135 C WS 27599368 + 8 [0]
--- fio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fio.h +1 -1
@@ -767,7 +767,7 @@ static inline bool should_check_rate(struct thread_data *td)if (!__should_check_rate (td))return false; -return ddir_rw_sum (td->bytes_done) !=0 ; +return true; }static inline unsigned long long td_max_bs (struct thread_data *td)
Signature · 1 line
1.8.3.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH] In the current implementation, should_check_rate() …
Hi Makus,
My apology for sending to the wrong mail list. Please ignore this email. I'll reformat it and send it to the fio maillist.
Regards,
Hongwei
Quoted 17 lines · Markus Elfring
Quoted 2 lines
This patch addresses the issue by not checking
td->bytes_doneinshould_check_rate.I suggest to improve the change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id94330a437a573cfdf848f6743b1ed169242c8a#n89Please choose a succinct patch subject.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id94330a437a573cfdf848f6743b1ed169242c8a#n569Quoted 1 line
+++
b/fio.hDo you refer to a header file from a special repository here?
https://github.com/axboe/fio/blame/4008b7fc8e2bff60a4e98de0005e6bc71b1a8641/fio.h#L765Regards,
Markus