scsi/qla4xxx: convert sysfs sprintf/snprintf family to sysfs_emit
Subsystems (2)
PATCH v3 1/1 scsi/qla4xxx: convert sysfs sprintf/snprintf family to sysfs_emit
Fix the following coccicheck warning:
./drivers/scsi/qla4xxx/ql4_attr.c: WARNING: use scnprintf or sprintf
Reported-by Abaci Robot<[email protected]>
Signed-off-by Jiapeng Zhong <[email protected]>
---
Changes in v3:
- convert sysfs_emit_at to sysfs_emit.
drivers/scsi/qla4xxx/ql4_attr.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/scsi/qla4xxx/ql4_attr.c +16 -16
@@ -156,11 +156,11 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha)struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev));if (is_qla80XX (ha)) -return snprintf (buf,PAGE_SIZE ,"%d.%02d.%02d (%x)\n" , +return sysfs_emit (buf,"%d.%02d.%02d (%x)\n" , ha->fw_info.fw_major, ha->fw_info.fw_minor, ha->fw_info.fw_patch, ha->fw_info.fw_build);else -return snprintf (buf,PAGE_SIZE ,"%d.%02d.%02d.%02d\n" , +return sysfs_emit (buf,"%d.%02d.%02d.%02d\n" , ha->fw_info.fw_major, ha->fw_info.fw_minor, ha->fw_info.fw_patch, ha->fw_info.fw_build); }
@@ -170,7 +170,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%s\n" , ha->serial_number); +return sysfs_emit (buf,"%s\n" , ha->serial_number); } static ssize_t
@@ -178,7 +178,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%d.%02d\n" , ha->fw_info.iscsi_major, +return sysfs_emit (buf,"%d.%02d\n" , ha->fw_info.iscsi_major, ha->fw_info.iscsi_minor); }
@@ -187,7 +187,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%d.%02d.%02d.%02d\n" , +return sysfs_emit (buf,"%d.%02d.%02d.%02d\n" , ha->fw_info.bootload_major, ha->fw_info.bootload_minor, ha->fw_info.bootload_patch, ha->fw_info.bootload_build); }
@@ -197,7 +197,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"0x%08X\n" , ha->board_id); +return sysfs_emit (buf,"0x%08X\n" , ha->board_id); } static ssize_t
@@ -207,7 +207,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha)struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev));qla4xxx_get_firmware_state (ha); -return snprintf (buf,PAGE_SIZE ,"0x%08X%8X\n" , ha->firmware_state, +return sysfs_emit (buf,"0x%08X%8X\n" , ha->firmware_state, ha->addl_fw_state); }
@@ -220,7 +220,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha)if (is_qla40XX (ha))return -ENOSYS ; -return snprintf (buf,PAGE_SIZE ,"0x%04X\n" , ha->phy_port_cnt); +return sysfs_emit (buf,"0x%04X\n" , ha->phy_port_cnt); } static ssize_t
@@ -232,7 +232,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha)if (is_qla40XX (ha))return -ENOSYS ; -return snprintf (buf,PAGE_SIZE ,"0x%04X\n" , ha->phy_port_num); +return sysfs_emit (buf,"0x%04X\n" , ha->phy_port_num); } static ssize_t
@@ -244,7 +244,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha)if (is_qla40XX (ha))return -ENOSYS ; -return snprintf (buf,PAGE_SIZE ,"0x%04X\n" , ha->iscsi_pci_func_cnt); +return sysfs_emit (buf,"0x%04X\n" , ha->iscsi_pci_func_cnt); } static ssize_t
@@ -253,7 +253,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%s\n" , ha->model_name); +return sysfs_emit (buf,"%s\n" , ha->model_name); } static ssize_t
@@ -261,7 +261,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%s %s\n" , ha->fw_info.fw_build_date, +return sysfs_emit (buf,"%s %s\n" , ha->fw_info.fw_build_date, ha->fw_info.fw_build_time); }
@@ -270,7 +270,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%s\n" , ha->fw_info.fw_build_user); +return sysfs_emit (buf,"%s\n" , ha->fw_info.fw_build_user); } static ssize_t
@@ -278,7 +278,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) char *buf) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%s\n" , ha->fw_info.extended_timestamp); +return sysfs_emit (buf,"%s\n" , ha->fw_info.extended_timestamp); } static ssize_t
@@ -300,7 +300,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha)break ; } -return snprintf (buf,PAGE_SIZE ,"%s\n" , load_src); +return sysfs_emit (buf,"%s\n" , load_src); } static ssize_t
@@ -309,7 +309,7 @@ void qla4_8xxx_free_sysfs_attr(struct scsi_qla_host *ha) {struct scsi_qla_host *ha =to_qla_host (class_to_shost (dev));qla4xxx_about_firmware (ha); -return snprintf (buf,PAGE_SIZE ,"%u.%u secs\n" , ha->fw_uptime_secs, +return sysfs_emit (buf,"%u.%u secs\n" , ha->fw_uptime_secs, ha->fw_uptime_msecs); }
Signature · 1 line
1.8.3.1