Skip to contentSkip to conversation

mm/swap_slots.c: remove redundant NULL check

PATCH Applied Yang Li 2 participants 2 messages Jan 21, 2021 – Feb 2, 2021 Memory management

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 mm/swap_slots.c: remove redundant NULL check

Fix below warnings reported by coccicheck:
./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed.

---
 mm/swap_slots.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/swap_slots.c +1 -2
index 0357fbe..be9de6d 100644
@@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
 			cache->slots_ret = NULL;
 		}
 		spin_unlock_irq(&cache->free_lock);
-		if (slots)
-			kvfree(slots);
+		kvfree(slots);
 	}
 }
 
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Yang Li

Fix below warnings reported by coccicheck:
./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed.

---
  mm/swap_slots.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
mm/swap_slots.c +0 -0
index 0357fbe..be9de6d 100644

mm/swap_slots.c static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type, · line 199

Quoted 9 lines
mm/swap_slots.c +1 -2
@@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
  			cache->slots_ret = NULL;
  		}
  		spin_unlock_irq(&cache->free_lock);
-		if (slots)
-			kvfree(slots);
+		kvfree(slots);
  	}
  }
 
Signature · 3 lines
Thanks,

David / dhildenb