Skip to contentSkip to conversation

mm/memcontrol: remove redundant NULL check

PATCH Applied Yang Li 2 participants 2 messages Jan 21, 2021 – Feb 2, 2021

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 mm/memcontrol: remove redundant NULL check

Fix below warnings reported by coccicheck:
./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing functions is not needed.

---
 mm/memcontrol.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/memcontrol.c +1 -2
index 605f671..f6a561b 100644
@@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
 	for_each_node(nid) {
 		pn = mem_cgroup_nodeinfo(memcg, nid);
 		map = rcu_dereference_protected(pn->shrinker_map, true);
-		if (map)
-			kvfree(map);
+		kvfree(map);
 		rcu_assign_pointer(pn->shrinker_map, NULL);
 	}
 }
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Yang Li

Fix below warnings reported by coccicheck:
./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing functions is not needed.

---
  mm/memcontrol.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
mm/memcontrol.c +0 -0
index 605f671..f6a561b 100644

mm/memcontrol.c static void memcg_free_shrinker_maps(struct mem_cgroup *memcg) · line 453

Quoted 9 lines
mm/memcontrol.c +1 -2
@@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
  	for_each_node(nid) {
  		pn = mem_cgroup_nodeinfo(memcg, nid);
  		map = rcu_dereference_protected(pn->shrinker_map, true);
-		if (map)
-			kvfree(map);
+		kvfree(map);
  		rcu_assign_pointer(pn->shrinker_map, NULL);
  	}
  }
Signature · 3 lines
Thanks,

David / dhildenb