Skip to contentSkip to conversation

ALSA: hda: Assign boolean values to a bool variable

PATCH Applied Jiapeng Zhong 2 participants 2 messages Jan 25, 2021 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: Assign boolean values to a bool variable

Fix the following coccicheck warnings:

./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of 0/1 to bool variable.

---
 sound/pci/hda/hda_intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/hda_intel.c +1 -1
index 5a50d3a..24e9762 100644
@@ -2304,7 +2304,7 @@ static int azx_probe_continue(struct azx *chip)
 
 		/* HSW/BDW controllers need this power */
 		if (CONTROLLER_IN_GPU(pci))
-			hda->need_i915_power = 1;
+			hda->need_i915_power = true;
 	}
 
 	/* Request display power well for the HDA controller or codec. For
Signature · 1 line
1.8.3.1
Applied
#1 lore raw
Quoted 8 lines · Jiapeng Zhong

Fix the following coccicheck warnings:

./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of 0/1 to bool variable.

Thanks, applied now.

But if you have some more similar changes, please try to convert at once instead of submitting each change infrequently. It's getting annoying now, as the change itself hardly helps improving the readability or code quality in general, although there is no strong reason to object it.

Takashi