media: firmware: qcom_scm: Simplify the calculation of variables
Quoted 5 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is equivalent to !A || B.
Reviewed-by Bjorn Andersson <[email protected]>
Quoted 22 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>--- drivers/firmware/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/qcom_scm.c +1
-1@@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus) .owner = ARM_SMCCC_OWNER_SIP, }; -if (!cpus || (cpus &&cpumask_empty (cpus))) +if (!cpus ||cpumask_empty (cpus))return -EINVAL ;for_each_cpu (cpu, cpus) {Signature · 1 line
1.8.3.1
PATCH 1/1 media: firmware: qcom_scm: Simplify the calculation of variables
Fix the following coccicheck warnings:
./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is equivalent to !A || B.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Zhong <[email protected]>
--- drivers/firmware/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/qcom_scm.c +1 -1
@@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus) .owner = ARM_SMCCC_OWNER_SIP, }; -if (!cpus || (cpus &&cpumask_empty (cpus))) +if (!cpus ||cpumask_empty (cpus))return -EINVAL ;for_each_cpu (cpu, cpus) {
Signature · 1 line
1.8.3.1