rtlwifi: halbtc8723b2ant: Remove redundant code
PATCH 1/1 rtlwifi: halbtc8723b2ant: Remove redundant code
Fix the following coccicheck warnings:
./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:
1876:11-13: WARNING: possible condition with no effect (if == else).
Reported-by Abaci Robot <[email protected]>
Suggested-by Jiapeng Zhong <[email protected]>
Signed-off-by Abaci Team <[email protected]>
--- .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 22 ---------------------- 1 file changed, 22 deletions(-)
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c +0 -22
@@ -1273,8 +1273,6 @@ static void btc8723b2ant_ps_tdma(struct btc_coexist *btcoexist, bool force_exec, }else {if (coex_sta->a2dp_bit_pool >=45 ) wifi_duration_adjust =-15 ; -else if (coex_sta->a2dp_bit_pool >=35 ) - wifi_duration_adjust =-10 ;else wifi_duration_adjust =-10 ; }
@@ -1805,11 +1803,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist,NORMAL_EXEC , true, 14); coex_dm->ps_tdma_du_adj_type =14 ; - }else if (max_interval ==3 ) { -btc8723b2ant_ps_tdma (btcoexist, -NORMAL_EXEC , - true,15 ); - coex_dm->ps_tdma_du_adj_type =15 ; }else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC,
@@ -1827,11 +1820,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist,NORMAL_EXEC , true, 10); coex_dm->ps_tdma_du_adj_type =10 ; - }else if (max_interval ==3 ) { -btc8723b2ant_ps_tdma (btcoexist, -NORMAL_EXEC , - true,11 ); - coex_dm->ps_tdma_du_adj_type =11 ; }else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC,
@@ -1851,11 +1839,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist,NORMAL_EXEC , true, 6); coex_dm->ps_tdma_du_adj_type =6 ; - }else if (max_interval ==3 ) { -btc8723b2ant_ps_tdma (btcoexist, -NORMAL_EXEC , - true,7 ); - coex_dm->ps_tdma_du_adj_type =7 ; }else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC,
@@ -1873,11 +1856,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist,NORMAL_EXEC , true, 2); coex_dm->ps_tdma_du_adj_type =2 ; - }else if (max_interval ==3 ) { -btc8723b2ant_ps_tdma (btcoexist, -NORMAL_EXEC , - true,3 ); - coex_dm->ps_tdma_du_adj_type =3 ; }else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC,
Signature · 1 line
1.8.3.1
Quoted 9 lines · Abaci Team
Fix the following coccicheck warnings:
./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:
1876:11-13: WARNING: possible condition with no effect (if == else).Reported-by Abaci Robot <[email protected]>Suggested-by Jiapeng Zhong <[email protected]>Signed-off-by Abaci Team <[email protected]>
Signed-off-by lines need to have a real name. SeeDocumentation/process/submitting-patches.rst
With that change
Acked-by Willem de Bruijn <[email protected]>