firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
PATCH 1/1 firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
From: Richard Gong <[email protected]>
This is a bug fix and needs to be backported to stable kernel releases.
Richard Gong (1):
firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
include/linux/firmware/intel/stratix10-svc-client.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/1 firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
From: Richard Gong <[email protected]>
Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which aligns with the firmware settings.
--- include/linux/firmware/intel/stratix10-svc-client.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/linux/firmware/intel/stratix10-svc-client.h +3 -3
@@ -51,12 +51,12 @@#define SVC_STATUS_NO_SUPPORT 6/* -* Flag bit for COMMAND_RECONFIG +* Flag for COMMAND_RECONFIG, in bit number * * COMMAND_RECONFIG_FLAG_PARTIAL: -* Set to FPGA configuration type (full or partial). +* Set for partial configuration. */ -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 +#define COMMAND_RECONFIG_FLAG_PARTIAL 0/* * Timeout settings for service clients:
Signature · 1 line
2.7.4
Quoted 4 lines · On 1/27/21 1:43 PM, [email protected] wrote:
From: Richard Gong <[email protected]>
Clean up
COMMAND_RECONFIG_FLAG_PARTIALflag by resetting it to 0, which aligns with the firmware settings.
For fixes, you need to have a 'Fixes: ... ' line in the comment.
This lets folks doing the stable branch know how far back to apply the fix.
For this case, this is likely
This should go right above your signoff.
By stand alone patch, this change should be split out from your current
[PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
So the next rev out your patch set will have 7 patches, because 1/6 is being split into two patches.
I would recommend the fix be 1/7, to minimize chance of conflicts merging it with stable.
or
submit the split out fix first.
Tom
Quoted 26 lines
Signed-off-by Richard Gong <[email protected]>--- include/linux/firmware/intel/stratix10-svc-client.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)include/linux/firmware/intel/stratix10-svc-client.h +3
-3@@ -51,12 +51,12 @@#define SVC_STATUS_NO_SUPPORT 6/* -* Flag bit for COMMAND_RECONFIG +* Flag for COMMAND_RECONFIG, in bit number * * COMMAND_RECONFIG_FLAG_PARTIAL: -* Set to FPGA configuration type (full or partial). +* Set for partial configuration. */ -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 +#define COMMAND_RECONFIG_FLAG_PARTIAL 0/* * Timeout settings for service clients:
Quoted 10 lines · Tom Rix
Quoted 4 lines · On 1/27/21 1:43 PM, [email protected] wrote:
From: Richard Gong <[email protected]>
Clean up
COMMAND_RECONFIG_FLAG_PARTIALflag by resetting it to 0, which aligns with the firmware settings.For fixes, you need to have a 'Fixes: ... ' line in the comment.
This lets folks doing the stable branch know how far back to apply the fix.
It is a nice hint, but not always needed, and is NOT how to trigger a patch to be backported to stable kernels. Please read the documentation on how to properly do that.
thanks,
greg k-h
Quoted 9 lines · On Wed, Jan 27, 2021 at 03:43:21PM -0600, [email protected] wrote:
From: Richard Gong <[email protected]>
Clean up
COMMAND_RECONFIG_FLAG_PARTIALflag by resetting it to 0, which aligns with the firmware settings.Signed-off-by Richard Gong <[email protected]>--- include/linux/firmware/intel/stratix10-svc-client.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>