mtd: rawnand: qcom: Update register macro name for 0x2c offset
PATCH 1/1 mtd: rawnand: qcom: Update register macro name for 0x2c offset
This change will remove unused register name macro NAND_DEV1_ECC_CFG. Since this register was only available in QPIC version 1.4.20 ipq40xx and it was not used. In QPIC version 1.5 on wards this register got removed.In QPIC version 2.0 0x2c offset is updated with register NAND_AUTO_STATUS_EN So adding this register macro NAND_AUTO_STATUS_EN with offset 0x2c.
--- drivers/mtd/nand/raw/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/raw/qcom_nandc.c +1 -1
@@ -27,7 +27,7 @@#define NAND_DEV0_CFG0 0x20#define NAND_DEV0_CFG1 0x24#define NAND_DEV0_ECC_CFG 0x28 -#define NAND_DEV1_ECC_CFG 0x2c +#define NAND_AUTO_STATUS_EN 0x2c#define NAND_DEV1_CFG0 0x30#define NAND_DEV1_CFG1 0x34#define NAND_READ_ID 0x40
Signature · 1 line
2.7.4
Quoted 8 lines · Md Sadre Alam
This change will remove unused register name macro
NAND_DEV1_ECC_CFG. Since this register was only available in QPIC version 1.4.20 ipq40xx and it was not used. In QPIC version 1.5 on wards this register got removed.In QPIC version 2.00x2coffset is updated with registerNAND_AUTO_STATUS_ENSo adding this register macroNAND_AUTO_STATUS_ENwith offset0x2c.Signed-off-by Md Sadre Alam <[email protected]>
Ping! Is any additional info needed for this patch ?
Quoted 10 lines
--- drivers/mtd/nand/raw/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mtd/nand/raw/qcom_nandc.c +0
-0
drivers/mtd/nand/raw/qcom_nandc.c line 33
Quoted 8 lines
drivers/mtd/nand/raw/qcom_nandc.c +1
-1@@ -27,7 +27,7 @@#define NAND_DEV0_CFG0 0x20#define NAND_DEV0_CFG1 0x24#define NAND_DEV0_ECC_CFG 0x28 -#define NAND_DEV1_ECC_CFG 0x2c +#define NAND_AUTO_STATUS_EN 0x2c#define NAND_DEV1_CFG0 0x30#define NAND_DEV1_CFG1 0x34#define NAND_READ_ID 0x40
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal
maintainerHello,
[email protected] wrote on Fri, 05 Feb 2021 23:26:33 +0530:
Quoted 11 lines · Md Sadre Alam
Quoted 8 lines
This change will remove unused register name macro
NAND_DEV1_ECC_CFG. Since this register was only available in QPIC version 1.4.20 ipq40xx and it was not used. In QPIC version 1.5 on wards this register got removed.In QPIC version 2.00x2coffset is updated with registerNAND_AUTO_STATUS_ENSo adding this register macroNAND_AUTO_STATUS_ENwith offset0x2c.Signed-off-by Md Sadre Alam <[email protected]>Ping! Is any additional info needed for this patch ?
The patch is fine but we are at -rc6, the NAND PR has already been sent, I don't plan to add more patches for this release. I will apply new patches at v5.12-rc1.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 8 lines · Md Sadre Alam
This change will remove unused register name macro
NAND_DEV1_ECC_CFG. Since this register was only available in QPIC version 1.4.20 ipq40xx and it was not used. In QPIC version 1.5 on wards this register got removed.In QPIC version 2.00x2coffset is updated with registerNAND_AUTO_STATUS_ENSo adding this register macroNAND_AUTO_STATUS_ENwith offset0x2c.Signed-off-by Md Sadre Alam <[email protected]>
Thanks,
Mani
Quoted 20 lines
--- drivers/mtd/nand/raw/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mtd/nand/raw/qcom_nandc.c +1
-1@@ -27,7 +27,7 @@#define NAND_DEV0_CFG0 0x20#define NAND_DEV0_CFG1 0x24#define NAND_DEV0_ECC_CFG 0x28 -#define NAND_DEV1_ECC_CFG 0x2c +#define NAND_AUTO_STATUS_EN 0x2c#define NAND_DEV1_CFG0 0x30#define NAND_DEV1_CFG1 0x34#define NAND_READ_ID 0x40Signature · 1 line
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 9 lines · Md Sadre Alam
This change will remove unused register name macro
NAND_DEV1_ECC_CFG. Since this register was only available in QPIC version 1.4.20 ipq40xx and it was not used. In QPIC version 1.5 on wards this register got removed.In QPIC version 2.00x2coffset is updated with registerNAND_AUTO_STATUS_ENSo adding this register macroNAND_AUTO_STATUS_ENwith offset0x2c.Signed-off-by Md Sadre Alam <[email protected]>Reviewed-by Manivannan Sadhasivam <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel